From 2c13a032b944932b5b26e20b24d356f6592bf0dd Mon Sep 17 00:00:00 2001
From: Matt Toohey <mtoohey@block.xyz>
Date: Tue, 4 Feb 2025 12:23:51 +1100
Subject: [PATCH] fix: provisioner no longer hosts service (#4279)

- No need for readiness checks on provisioner.
- No need for provisioner-service.yaml now that there is no service
- Rename cron file for consistency
---
 .../{cron-deployment.yaml => cron.yaml}       |  0
 .../ftl/templates/provisioner-services.yaml   | 24 -------------------
 charts/ftl/templates/provisioner.yaml         | 13 ----------
 3 files changed, 37 deletions(-)
 rename charts/ftl/templates/{cron-deployment.yaml => cron.yaml} (100%)
 delete mode 100644 charts/ftl/templates/provisioner-services.yaml

diff --git a/charts/ftl/templates/cron-deployment.yaml b/charts/ftl/templates/cron.yaml
similarity index 100%
rename from charts/ftl/templates/cron-deployment.yaml
rename to charts/ftl/templates/cron.yaml
diff --git a/charts/ftl/templates/provisioner-services.yaml b/charts/ftl/templates/provisioner-services.yaml
deleted file mode 100644
index a734fe60b7..0000000000
--- a/charts/ftl/templates/provisioner-services.yaml
+++ /dev/null
@@ -1,24 +0,0 @@
-apiVersion: v1
-kind: Service
-metadata:
-  labels:
-    {{- include "ftl.labels" . | nindent 4 }}
-  name: {{ include "ftl.fullname" . }}-provisioner
-  {{- if .Values.provisioner.service.annotations }}
-  annotations:
-    {{- toYaml .Values.provisioner.service.annotations | nindent 4 }}
-  {{- end }}
-spec:
-  ports:
-    {{- range .Values.provisioner.service.ports }}
-    - name: {{ .name }}
-      port: {{ .port }}
-      protocol: {{ .protocol | default "TCP" }}
-      {{- if .appProtocol }}
-      appProtocol: {{ .appProtocol }}
-      {{- end }}
-      targetPort: {{ .targetPort }}
-    {{- end }}
-  selector:
-    {{- include "ftl-provisioner.selectorLabels" . | nindent 4 }}
-  type: {{ .Values.provisioner.service.type | default "ClusterIP" }}
\ No newline at end of file
diff --git a/charts/ftl/templates/provisioner.yaml b/charts/ftl/templates/provisioner.yaml
index a04d7cc6bd..d31702589b 100644
--- a/charts/ftl/templates/provisioner.yaml
+++ b/charts/ftl/templates/provisioner.yaml
@@ -47,19 +47,6 @@ spec:
               containerPort: {{ .containerPort }}
               protocol: {{ .protocol | default "TCP" }}
             {{- end }}
-          readinessProbe:
-            {{- if .Values.provisioner.readinessProbe }}
-            {{- toYaml .Values.provisioner.readinessProbe | nindent 12 }}
-            {{- else }}
-            httpGet:
-              path: /healthz
-              port: {{ (index .Values.provisioner.ports 0).containerPort }}
-            initialDelaySeconds: 1
-            periodSeconds: 2
-            timeoutSeconds: 2
-            successThreshold: 1
-            failureThreshold: 15
-            {{- end }}
           volumeMounts:
             - mountPath: /config
               name: config