Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Attaching file while writing message overwrites message #1179

Open
lily-de opened this issue Feb 10, 2025 · 0 comments · May be fixed by #1228
Open

bug: Attaching file while writing message overwrites message #1179

lily-de opened this issue Feb 10, 2025 · 0 comments · May be fixed by #1228
Labels
bug Something isn't working ui

Comments

@lily-de
Copy link
Collaborator

lily-de commented Feb 10, 2025

Describe the bug
A clear and concise description of what the bug is.

If you append a file in the UI to a goose session, it overwrites your message to goose. We should be able to attach files and include a message to goose about what we want goose to do with that file, and if you start writing a message first then attach it should not overwrite your message

To Reproduce
Steps to reproduce the behavior:

  1. Start writing a message to goose
  2. Before submitting the message, click the paperclip icon and select any file
  3. Message from step 1 disappears and is replaced by a path to the file selected in step 2

Expected behavior
A clear and concise description of what you expected to happen.

    1. Start writing a message to goose
  2. Before submitting the message, click the paperclip icon and select any file
  3. Message from step 1 remains and path for file selected in step 2 remains

Screenshots
If applicable, add screenshots to help explain your problem.

Please provide following information:

  • Interface: UI
  • Version: v1.0.5

Additional context
Add any other context about the problem here.
@lily-de lily-de added bug Something isn't working ui labels Feb 10, 2025
mhickman added a commit to mhickman/goose that referenced this issue Feb 13, 2025
@mhickman
fix: append filename to text input
31fb2de 
Instead of clobbering the input text area just append the file path
at the end of the input.

This could be more clever by tracking where the cursor _was_ and inserting
the text there, but this seems better than just deleting the text.

Fixes block#1179
@mhickman mhickman linked a pull request Feb 13, 2025 that will close this issue
Open
mhickman added a commit to mhickman/goose that referenced this issue Feb 14, 2025
@mhickman
fix: add filename to existing text
e45bd40 
Instead of clobbering the input text area, add to where the cursor last was.

Fixes block#1179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add filename to existing text mhickman/goose
1 participant
@lily-de