-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request] Publish assets on NPM for use with Webpacker #7
Comments
Hi @Fs00! I have just added a basic Webpacker support in master branch. At the moment, I prefer to avoid keeping a version of the package also in NPM - but as described - you can install the JS package directly from Github. For now I disabled the icomoon font inclusion, because I'll need to make some extra check to include the font via JS. Please let me know if you make some tests. |
Great, thank you! Will let you know when I try it. |
Hi @Fs00. I have just prepared a release with Webpacker support and with some updates to the install instructions in the README. |
Not yet, will try in the next days. |
Tested locally and everything seems to work nicely! (except the known issue of missing icons ofc) The only (workaroundable) problem I encountered with this comes from not using NPM. We use this theme in an enterprise application which is built in an environment that isn't connected to the outside world, therefore all dependencies must be available on the company's internal mirrors. Anyway, I will accept your decision whether you will upload it on NPM or not. |
I see your point 🤔 Is the gem available in a local path? |
It would be a nice solution, but sadly wouldn't work in your scenario because of differences in the way we install gems in a local dev environment vs in the CI pipeline. |
What about using a private mirror for packages? Like this tool for NPM: https://github.com/local-npm/local-npm |
As I said above, the company has a private NPM mirror that we can use to upload the package. The only problem is that we don't have direct control over that mirror, so we must ask other people to upload the dependency for us (which is perfectly doable, it's only less practical than pulling in the package directly from the official NPM registry). Looking forward to have working icons out-of-the-box on Webpacker now😉 |
Hello!
Could you publish an NPM package containing gem assets (CSS, fonts) so that they can be used together with Webpacker?
Currently we need to copy all the assets in our codebase in order to use Webpacker, which is not great for obvious reasons.
Also, in the future ActiveAdmin will adopt Webpacker by default (see activeadmin/activeadmin#6781 (comment)).
Thanks!
The text was updated successfully, but these errors were encountered: