Skip to content

refactor: akmods possibly needs to adjust to some upstream changes #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fiftydinar opened this issue Apr 17, 2024 · 8 comments
Closed

Comments

@fiftydinar
Copy link
Collaborator

fiftydinar commented Apr 17, 2024

ublue-os/akmods#176

ublue-os/akmods#171 (comment)

Upstream akmods refactor is not yet done, so we will see if there is anything else that needs to be done

@fiftydinar fiftydinar changed the title refactor: akmods possibly needs to adjust to these changes refactor: akmods possibly needs to adjust to some upstream changes Apr 17, 2024
@fiftydinar
Copy link
Collaborator Author

@gmpinder
Since akmods is a hybrid between bash & bluebuild-cli module, those changes are also affecting you, so I'm pinging

@gmpinder
Copy link
Member

gmpinder commented Apr 17, 2024

Ok so it's looking like we will need to remove the version prop and just use base. But we also need to have a way to specify the need for the nvidia image.

@lorduskordus
Copy link
Contributor

My build is failing now:

0.238 ========== Start Akmods module ==========
0.569 Installing akmods
0.572 Installing: VirtualBox
0.606 error: Handling argument /tmp/rpms/kmods/*VirtualBox*.rpm: No such file or directory (os error 2)

@fiftydinar
Copy link
Collaborator Author

fiftydinar commented Apr 27, 2024

My build is failing now:

0.238 ========== Start Akmods module ==========
0.569 Installing akmods
0.572 Installing: VirtualBox
0.606 error: Handling argument /tmp/rpms/kmods/*VirtualBox*.rpm: No such file or directory (os error 2)

This happens because Universal Blue separated akmods into akmods & akmods-extra Containerfile, to make a better separation between most frequently used akmods & community requested/made akmods.

VirtualBox akmod now resides in akmods-extra Containerfile, which we don't pull yet, but fix is easy, so this will be fixed soon.

@fiftydinar
Copy link
Collaborator Author

@lorduskordus Your reported issue is fixed, but usage of unstable CLI is required, until new GitHub Action gets released:

https://blue-build.org/reference/github-action/#use_unstable_cli-optional

This PR fixed it:
blue-build/cli#169

@fiftydinar
Copy link
Collaborator Author

All adapting akmods changes are done, but I will keep the issue open, until new BlueBuild GitHub Action gets released.

@fiftydinar
Copy link
Collaborator Author

Unfortunately, GH Action v1.4.0 released today uses BlueBuild CLI v0.8.4 but support for extra akmods is in v0.8.5, so I will still have to keep this issue open.

This means that usage of unstable CLI is still required.

@gmpinder
Copy link
Member

gmpinder commented May 2, 2024

Unfortunately, GH Action v1.4.0 released today uses BlueBuild CLI v0.8.4 but support for extra akmods is in v0.8.5, so I will still have to keep this issue open.

This means that usage of unstable CLI is still required.

New GHA version was released today containing those fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants