fix: Improve error handling

Author: Pinguin2001

src/App.xaml.cs

@@ -6,10 +6,17 @@ public App()
     {
         this.InitializeComponent();
         this.Suspending += OnSuspending;
+        this.UnhandledException += App_UnhandledException;
         LoadSettings();
         FavoritesHelper.LoadFavoritesOnStartup();
     }
 
+    private void App_UnhandledException(object sender, Windows.UI.Xaml.UnhandledExceptionEventArgs e)
+    {
+        NotificationHelper.NotifyUser("An error occured", "An unhandled exception occured, the app my be in an unstable state.\nPlease restart Bluebird as soon as possible.");
+        e.Handled = true;
+    }
+
     private void LoadSettings()
     {
         SearchUrl = SettingsHelper.GetSetting("SearchUrl") ?? "https://www.qwant.com/?q=";

src/Bluebird.csproj

@@ -1,12 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
-  <PropertyGroup Condition="'$(Configuration)' == 'Release'">
-    <!-- disable generation of stack trace metadata (needed by Exception.ToString() in NET Native) -->
-    <DisableStackTraceMetadata>true</DisableStackTraceMetadata>
-    <!-- disables generation of exception messages in framework-thrown exceptions -->
-    <DisableExceptionMessages>true</DisableExceptionMessages>
-  </PropertyGroup>
   <PropertyGroup>
     <AccelerateBuildsInVisualStudio>true</AccelerateBuildsInVisualStudio>
     <LangVersion>12</LangVersion>
@@ -117,6 +111,7 @@
     </Compile>
     <Compile Include="Core\AppStartupHelper.cs" />
     <Compile Include="Core\ModernBlankPage.cs" />
+    <Compile Include="Core\WebView2CreationError.cs" />
     <Compile Include="Core\XAMLTabCreationParams.cs" />
     <Compile Include="Core\NewTabHelper.cs" />
     <Compile Include="Core\NotificationHelper.cs" />
@@ -162,6 +157,9 @@
     <Compile Include="Pages\SplitTabPage.xaml.cs">
       <DependentUpon>SplitTabPage.xaml</DependentUpon>
     </Compile>
+    <Compile Include="Pages\WebViewErrorPage.xaml.cs">
+      <DependentUpon>WebViewErrorPage.xaml</DependentUpon>
+    </Compile>
     <Compile Include="Pages\WebViewPage.xaml.cs">
       <DependentUpon>WebViewPage.xaml</DependentUpon>
     </Compile>
@@ -299,6 +297,10 @@
       <SubType>Designer</SubType>
       <Generator>MSBuild:Compile</Generator>
     </Page>
+    <Page Include="Pages\WebViewErrorPage.xaml">
+      <Generator>MSBuild:Compile</Generator>
+      <SubType>Designer</SubType>
+    </Page>
     <Page Include="Pages\WebViewPage.xaml">
       <Generator>MSBuild:Compile</Generator>
       <SubType>Designer</SubType>

src/Core/WebView2CreationError.cs

@@ -0,0 +1,6 @@
+namespace Bluebird.Core;
+
+public class WebView2CreationError(string ErrorMsg)
+{
+    public string ErrorMsg { get; private set; } = ErrorMsg;
+}

src/Pages/WebViewErrorPage.xaml

@@ -0,0 +1,19 @@
+<Page
+    x:Class="Bluebird.Pages.WebViewErrorPage"
+    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
+    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
+    xmlns:local="using:Bluebird.Pages"
+    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
+    mc:Ignorable="d">
+
+    <Grid
+        x:Name="pageChrome"
+        HorizontalAlignment="Stretch"
+        VerticalAlignment="Stretch"
+        Style="{StaticResource PageBorder}">
+        <ScrollViewer>
+            <StackPanel x:Name="ErrorList" />
+        </ScrollViewer>
+    </Grid>
+</Page>

src/Pages/WebViewErrorPage.xaml.cs

@@ -0,0 +1,41 @@
+namespace Bluebird.Pages;
+
+public sealed partial class WebViewErrorPage : Page
+{
+    public WebViewErrorPage()
+    {
+        this.InitializeComponent();
+    }
+
+    protected override void OnNavigatedTo(NavigationEventArgs e)
+    {
+        base.OnNavigatedTo(e);
+
+        string ErrorMsg = string.Empty;
+        if (e.Parameter != null)
+        {
+            var parameters = (WebView2CreationError)e.Parameter;
+            ErrorMsg = parameters.ErrorMsg;
+        }
+
+        muxc.InfoBar infoBar = new()
+        {
+            IsOpen = true,
+            Severity = muxc.InfoBarSeverity.Error,
+            Title = "An error occured",
+            Message = "Read the details below",
+            IsClosable = false
+        };
+        ErrorList.Children.Add(infoBar);
+
+        if (!string.IsNullOrEmpty(ErrorMsg))
+        {
+            TextBlock ErrorMsgDisplay = new()
+            {
+                Text = ErrorMsg,
+                IsTextSelectionEnabled = true
+            };
+            ErrorList.Children.Add(ErrorMsgDisplay);
+        }
+    }
+}

src/Pages/WebViewPage.xaml.cs

@@ -32,13 +32,10 @@ private async void WebViewControl_Loaded(object sender, RoutedEventArgs e)
         {
             await (sender as muxc.WebView2).EnsureCoreWebView2Async();
         }
-        catch
+        catch (Exception ex)
         {
-            var result = await UI.ShowDialogWithAction("Error", "WebView2 Runtime is not installed which is required to display webpages", "Download WebView2 Runtime", "Close App");
-            if (result == ContentDialogResult.Primary)
-                await Launcher.LaunchUriAsync(new Uri("https://go.microsoft.com/fwlink/p/?LinkId=2124703"));
-            else
-                CoreApplication.Exit();
+            WebViewControl?.Close();
+            Frame.Navigate(typeof(WebViewErrorPage), new WebView2CreationError(ex.StackTrace), new DrillInNavigationTransitionInfo());
         }
     }