Do softer version check. (#728)

* Do softer version check.

* Fix typos

* Emit warning for invalid tiled client version

* test_client_version_check checks for warning and log entry

---------

Co-authored-by: Padraic Shafer <76011594+padraic-shafer@users.noreply.github.com>
Co-authored-by: Padraic Shafer <pshafer@bnl.gov>

Author: danielballan

tiled/_tests/test_client.py

@@ -1,3 +1,4 @@
+import logging
 from pathlib import Path
 
 import httpx
@@ -22,7 +23,7 @@ def test_configurable_timeout():
         assert context.http_client.timeout.read == 17
 
 
-def test_client_version_check():
+def test_client_version_check(caplog):
     with Context.from_app(build_app(tree)) as context:
         client = from_context(context)
 
@@ -31,11 +32,21 @@ def test_client_version_check():
         with fail_with_status_code(HTTP_400_BAD_REQUEST):
             list(client)
 
-        # Gibberish user agent should generate a 400.
+        # Gibberish user agent should generate a warning and log entry.
         context.http_client.headers["user-agent"] = "python-tiled/gibberish"
-        with fail_with_status_code(HTTP_400_BAD_REQUEST):
+        caplog.set_level(logging.WARNING)
+        with pytest.warns(UserWarning, match=r"gibberish"):
             list(client)
 
+        _, LOG_LEVEL, LOG_MESSAGE = range(3)
+        logged_warnings = tuple(
+            entry[LOG_MESSAGE]
+            for entry in caplog.record_tuples
+            if entry[LOG_LEVEL] == logging.WARNING
+        )
+        assert len(logged_warnings) > 0
+        assert any("gibberish" in message for message in logged_warnings)
+
 
 def test_direct(tmpdir):
     profile_content = {

tiled/server/app.py

@@ -5,6 +5,7 @@
 import secrets
 import sys
 import urllib.parse
+import warnings
 from contextlib import asynccontextmanager
 from functools import lru_cache, partial
 from pathlib import Path
@@ -715,18 +716,18 @@ async def client_compatibility_check(request: Request, call_next):
             agent, _, raw_version = user_agent.partition("/")
             try:
                 parsed_version = packaging.version.parse(raw_version)
-            except Exception:
-                return JSONResponse(
-                    status_code=HTTP_400_BAD_REQUEST,
-                    content={
-                        "detail": (
-                            f"Python Tiled client is version is reported as {raw_version}. "
-                            "This cannot be parsed as a valid version."
-                        ),
-                    },
+            except Exception as caught_exception:
+                invalid_version_message = (
+                    f"Python Tiled client version is reported as {raw_version}. "
+                    "This cannot be parsed as a valid version."
                 )
+                logger.warning(invalid_version_message)
+                if isinstance(caught_exception, packaging.version.InvalidVersion):
+                    warnings.warn(invalid_version_message)
             else:
-                if parsed_version < MINIMUM_SUPPORTED_PYTHON_CLIENT_VERSION:
+                if (not parsed_version.is_devrelease) and (
+                    parsed_version < MINIMUM_SUPPORTED_PYTHON_CLIENT_VERSION
+                ):
                     return JSONResponse(
                         status_code=HTTP_400_BAD_REQUEST,
                         content={