Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orjson required for (writing from?) client, but isn't in client dependencies #636

Closed
pbeaucage opened this issue Jan 22, 2024 · 2 comments
Closed

orjson required for (writing from?) client, but isn't in client dependencies #636

pbeaucage opened this issue Jan 22, 2024 · 2 comments
Assignees
@Kezzsim

Comments

@pbeaucage
Copy link
Contributor

A Tiled client, when writing to a server using write_array, uses orjson to serialize the metadata, which I believe was a change introduced at some point. However, orjson is only a dependency in server and minimal-server which means it isn't installed when doing pip install tiled[client] and the client hits an import error during write which is not ideal.
@danielballan
Copy link
Member

Good catch! Thanks for reporting.

@Kezzsim Kezzsim mentioned this issue Jan 23, 2024
Merged
danielballan pushed a commit that referenced this issue Jan 23, 2024
@Kezzsim
Fix orjson client requirements (issue #636) 📦 (#639)
fca4330 
* Add orjson package to client & client-minimal 📦

* 🔠 Sort packages alphabetically
@danielballan
Copy link
Member

Closed by #639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kezzsim Kezzsim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pbeaucage @danielballan @Kezzsim