Skip to content

Refine logging of database creation #721

@danielballan

Description

@danielballan

I like that #714 logs catalog creation, but I think ERROR-level logging is not quite right. I suspect the original thinking was, "We're capturing 'standard error', so log to 'error'." But you get effects like this which I think can create the wrong impression that something is broken:

tiled/_tests/test_access_control.py::test_service_principal_access 
-------------------------------------------------------- live log call ---------------------------------------------------------
2024-04-19 10:36:30 [   ERROR] Subprocess stderr: Database sqlite+aiosqlite:////tmp/pytest-of-dallan/pytest-80/test_service_principal_access0/catalog.db is new. Creating tables.
Database initialized.
 (adapter.py:1314)
2024-04-19 10:36:32 [   ERROR] Subprocess stderr:  (adapter.py:1314)
PASSED                                                              

Maybe we can change this to INFO-level logging. I am imagine @dylanmcreynolds will be happy as long as the log message is visible for his use case(s). Can you past in here the workflows where you want to see this log message, Dylan?

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions