Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hint preview fixes #411

Closed
gorkem-bwl opened this issue Dec 21, 2024 · 0 comments · Fixed by #417
Closed

Hint preview fixes #411

gorkem-bwl opened this issue Dec 21, 2024 · 0 comments · Fixed by #417
Assignees
@erenfn
Labels
bug Something isn't working design just design in figma frontend Frontend task/issue
Milestone
1.0

Comments

@gorkem-bwl
Copy link
Contributor

  1. The header should have a left margin as seen here.
image
  1. We can increase the line height to 24px just like the Figma design.
image
  1. Color of the header is #484848 and the text is #344054

This must be reflected in all editors (popup, hint, banner)
@gorkem-bwl gorkem-bwl added bug Something isn't working frontend Frontend task/issue design just design in figma labels Dec 21, 2024
@gorkem-bwl gorkem-bwl added this to the 1.0 milestone Dec 21, 2024
@gorkem-bwl gorkem-bwl mentioned this issue Dec 22, 2024
Closed
@erenfn erenfn assigned erenfn and unassigned thomastepi Dec 22, 2024
@erenfn erenfn mentioned this issue Dec 22, 2024
Merged
@erenfn erenfn linked a pull request Dec 22, 2024 that will close this issue
Hint preview fix #417
Merged
@erenfn erenfn closed this as completed Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erenfn erenfn

Labels
bug Something isn't working design just design in figma frontend Frontend task/issue
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Hint preview fix bluewave-labs/guidefox
3 participants
@thomastepi @erenfn @gorkem-bwl