Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#66 - updated general settings #107

Merged
merged 6 commits into from
Aug 9, 2024
Merged

#66 - updated general settings #107

merged 6 commits into from
Aug 9, 2024

Conversation

kamilpiech97
Copy link
Member

Should close #66.
Added option to manage primary, secondary color and logo file.
Added tests.

@kamilpiech97 kamilpiech97 requested a review from a team as a code owner August 8, 2024 07:28
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When I upload logo ~15 MB size, I see error

image

  1. Please fix GitHub check annotations

image

  1. I changed primary and secondary colors and logo - I don't see that anywhere the colors is changed nor logo.

  2. Can we change style of color input? Now it looks like this

image

Something like this will look much better

image

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I set some image as a logo in "Ustawienia" -> I go to another page like "Studenci" -> I go one more time to "Ustawienia" -> I change primary color -> I click "Zapisz" button -> I see error "Pole logo musi być obrazkiem."

@kamilpiech97
Copy link
Member Author

  1. I set some image as a logo in "Ustawienia" -> I go to another page like "Studenci" -> I go one more time to "Ustawienia" -> I change primary color -> I click "Zapisz" button -> I see error "Pole logo musi być obrazkiem."

fixed

@kamilpiech97
Copy link
Member Author

  1. When I upload logo ~15 MB size, I see error

image

  1. Please fix GitHub check annotations

image

  1. I changed primary and secondary colors and logo - I don't see that anywhere the colors is changed nor logo.
  2. Can we change style of color input? Now it looks like this

image

Something like this will look much better

image

1,2,4 fixed
3. we should use that colors for theming but in another task.

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I still have error when I upload file like ~15MB
  2. I still have problem with that

I set some image as a logo in "Ustawienia" -> I go to another page like "Studenci" -> I go one more time to "Ustawienia" -> I change primary color -> I click "Zapisz" button -> I see error "Pole logo musi być obrazkiem."

@kamilpiech97 kamilpiech97 merged commit 06a63d2 into main Aug 9, 2024
3 checks passed
@kamilpiech97 kamilpiech97 deleted the #66-general-settings branch August 9, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional general settings
2 participants