Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 14 Windows CI tests failing sometimes #288

Closed
bmish opened this issue Nov 26, 2022 · 1 comment
Closed

Node 14 Windows CI tests failing sometimes #288

bmish opened this issue Nov 26, 2022 · 1 comment
Labels
Milestone

Comments

@bmish
Copy link
Owner

bmish commented Nov 26, 2022

I believe we just need to increase the timeout for the tests under Node 14 CI. The below workaround we applied for Node 14 causes the tests to take longer.

if (process.version.startsWith('v14.')) {
// TODO: remove this workaround after dropping support for Node 14.
// Use number greater than number of test suites to avoid: "You are trying to `import` a file after the Jest environment has been torn down."
// https://github.com/facebook/jest/issues/11438#issuecomment-954155180
jestConfig.maxConcurrency = 30;
jestConfig.maxWorkers = 30;

We can also wait until we drop support for Node 14 after it becomes EOL in April 2023.

@MikeMcC399
Copy link
Contributor

@bmish

This issue is now obsolete and could be closed.

@ddzz ddzz closed this as completed Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants