fix stack too deep

Author: YouStillAlive

contracts/BNBPartyLiquidity.sol

@@ -31,8 +31,8 @@ abstract contract BNBPartyLiquidity is BNBPartySwaps {
             amount1,
             sqrtPrice,
             party.partyLpFee,
-            party.partyTickLower,
-            party.partyTickUpper
+            party.partyTicks.tickLower,
+            party.partyTicks.tickUpper
         );
         isParty[liquidityPool] = true; // Mark the liquidity pool as a party pool
         isTokenOnPartyLP[_token] = true; // Mark the token as part of the party LP
@@ -140,7 +140,7 @@ abstract contract BNBPartyLiquidity is BNBPartySwaps {
         IERC20(token0).approve(address(positionManager), amount0);
         IERC20(token1).approve(address(positionManager), amount1);
         // Create new Liquidity Pool
-        _createLP(positionManager, token0, token1, amount0, amount1, newSqrtPriceX96, party.lpFee, party.tickLower, party.tickUpper);
+        _createLP(positionManager, token0, token1, amount0, amount1, newSqrtPriceX96, party.lpFee, party.lpTicks.tickLower, party.lpTicks.tickUpper);
 
         // Send bonuses
         _unwrapAndSendBNB(recipient, unwrapAmount);

contracts/BNBPartyView.sol

@@ -78,8 +78,8 @@ abstract contract BNBPartyView is BNBPartyModifiers {
             keccak256(
                 abi.encodePacked(
                     address(positionManager),
-                    party.tickLower,
-                    party.tickUpper
+                    party.lpTicks.tickLower,
+                    party.lpTicks.tickUpper
                 )
             )
         );
@@ -103,8 +103,8 @@ abstract contract BNBPartyView is BNBPartyModifiers {
             keccak256(
                 abi.encodePacked(
                     address(BNBPositionManager),
-                    party.partyTickLower,
-                    party.partyTickUpper
+                    party.partyTicks.tickLower,
+                    party.partyTicks.tickUpper
                 )
             )
         );

contracts/interfaces/IBNBPartyFactory.sol

@@ -30,10 +30,13 @@ interface IBNBPartyFactory {
         uint256 bonusTargetReach; // Bonus amount given if the party target is reached.
         uint256 bonusPartyCreator; // Bonus amount for the party creator.
         uint256 targetReachFee; // Fee charged upon reaching the target.
-        int24 partyTickLower; // Lower bound of the tick range for the Party liquidity pool.
-        int24 partyTickUpper; // Upper bound of the tick range for the Party liquidity pool.
-        int24 tickLower; // Lower bound of the tick range for the liquidity pool.
-        int24 tickUpper; // Upper bound of the tick range for the liquidity pool.
+        ticks partyTicks; // The tick range for the party's liquidity pool.
+        ticks lpTicks; // The tick range for the second liquidity pool.
+    }
+
+    struct ticks {
+        int24 tickLower;
+        int24 tickUpper;
     }
 
     /// @notice Event emitted when a new party is started.

test/BNBPartyFactory.ts

@@ -46,10 +46,8 @@ describe("BNBPartyFactory", function () {
         expect((await bnbPartyFactory.party()).lpFee).to.equal(FeeAmount.HIGH)
         expect((await bnbPartyFactory.party()).partyLpFee).to.equal(FeeAmount.HIGH)
         expect((await bnbPartyFactory.party()).createTokenFee).to.equal(tokenCreationFee)
-        expect((await bnbPartyFactory.party()).partyTickUpper).to.equal("195600")
-        expect((await bnbPartyFactory.party()).partyTickLower).to.equal("-214200")
-        expect((await bnbPartyFactory.party()).tickUpper).to.equal("201400")
-        expect((await bnbPartyFactory.party()).tickLower).to.equal("-214200")
+        expect((await bnbPartyFactory.party()).partyTicks.tickUpper).to.equal("195600")
+        expect((await bnbPartyFactory.party()).partyTicks.tickLower).to.equal("-214200")
     })
 
     it("should create party LP", async function () {

test/helper.ts

@@ -60,10 +60,8 @@ export async function deployContracts(partyTarget = ethers.parseEther("90")) {
             bonusTargetReach: returnFeeAmount,
             bonusPartyCreator: bonusFee,
             targetReachFee: targetReachFee,
-            partyTickLower: "-214200",
-            partyTickUpper: "195600",
-            tickLower: "-214200",
-            tickUpper: "201400",
+            partyTicks: { tickLower: "-214200", tickUpper: "195600" },
+            lpTicks: { tickLower: "-214200", tickUpper: "201400" },
         },
         await weth9.getAddress()
     )) as BNBPartyFactory
@@ -112,7 +110,7 @@ export async function deployContracts(partyTarget = ethers.parseEther("90")) {
     // Set Swap Router in BNBPartyFactory
     await bnbPartyFactory.setBNBPartySwapRouter(await BNBSwapRouter.getAddress())
     await bnbPartyFactory.setSwapRouter(await swapRouter.getAddress())
-    
+
     const liquidityAmountsCalculatorContract = await ethers.getContractFactory("LiquidityAmountsCalculator")
     const liquidityAmountsCalculator = (await liquidityAmountsCalculatorContract.deploy()) as LiquidityAmountsCalculator
     await bnbPartyFactory.setLiquidityAmountsCalculator(await liquidityAmountsCalculator.getAddress())