From 859630aaa983906696d1e3141f0a93f4565ae52b Mon Sep 17 00:00:00 2001 From: Adrian Andersen Date: Sun, 7 Jul 2024 15:33:39 +0200 Subject: [PATCH] fix(postal-code-lookup): move length check to verify spec --- .../delivery/operations/postal-code-lookup.operation.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/collections/delivery/operations/postal-code-lookup.operation.ts b/src/collections/delivery/operations/postal-code-lookup.operation.ts index acc2213d..df2a3967 100644 --- a/src/collections/delivery/operations/postal-code-lookup.operation.ts +++ b/src/collections/delivery/operations/postal-code-lookup.operation.ts @@ -29,7 +29,9 @@ export function verifyPostalCodeLookupSpec( postalCodeSpec: unknown, ): postalCodeSpec is PostalCodeLookupSpec { const m = postalCodeSpec as Record | null | undefined; - return !!m && typeof m["postalCode"] === "string"; + return ( + !!m && typeof m["postalCode"] === "string" && m["postalCode"].length !== 4 + ); } export class PostalCodeLookupOperation implements Operation { @@ -44,9 +46,6 @@ export class PostalCodeLookupOperation implements Operation { if (!verifyPostalCodeLookupSpec(postalCodeLookupSpec)) { throw new BlError(`Malformed PostalCodeSpec`).code(701); } - if (postalCodeLookupSpec.postalCode.length !== 4) { - return new BlapiResponse([{ postalCity: null }]); - } const bringAuthHeaders = { "X-MyBring-API-Key": process.env["BRING_API_KEY"], "X-MyBring-API-Uid": process.env["BRING_API_ID"],