Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable card on wallet deletion #4

Open
robertclarkson opened this issue Mar 6, 2023 · 3 comments
Open

Disable card on wallet deletion #4

robertclarkson opened this issue Mar 6, 2023 · 3 comments

Comments

@robertclarkson
Copy link
Member

The card probably shouldnt work if the wallet has been deleted. We should disable the card on wallet deletion.
@PeterRounce
Copy link
Member

The card probably shouldnt work if the wallet has been deleted. We should disable the card on wallet deletion.

That would be my expectation as a user of the system as well.

How about the situation where a wallet is exported and deleted, and them imported?
As a user, I'd expect the card to work against the imported wallet.

@robertclarkson
Copy link
Member Author

I think the user should have to manually re-enable the card after re-importing

@PeterRounce
Copy link
Member

Yes, I think that is also reasonable.

Maybe the UI could treat it like a normal 'connect card' and deal with it transparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertclarkson @PeterRounce