Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV: flag /entryPointExcludes is broken #57

Open
shaobo-he opened this issue Oct 31, 2017 · 1 comment
Open

AV: flag /entryPointExcludes is broken #57

shaobo-he opened this issue Oct 31, 2017 · 1 comment

Comments

@shaobo-he
Copy link
Collaborator

shaobo-he commented Oct 31, 2017

There are a couple of issues with this flag.

  1. When multiple such flags are given to fastavn, they are not passed along to avh properly. The relevant code is

    if (entryPointExcludes != null)
    {
    entryPointExcludes.Iter(s => avHarnessInstrArgs += string.Format("/entryPointExcludes:{0}", s));
    }
    . There should be spaces between these args.

  2. Avh doesn't seem to take this flag into account. The loop exit condition (

    if (useProvidedEntryPoints && !QKeyValue.FindBoolAttribute(impl.Proc.Attributes, "entrypoint"))
    continue;
    ) doesn't prevent procedures specified by this flag from being instrumented.

I can create a PR for the first one.

shaobo-he added a commit that referenced this issue Oct 31, 2017
@zvonimir
Copy link
Collaborator

I am guessing nobody will work on this any time soon, if ever.
@shuvendu-lahiri and @akashlal : are you ok if I mark this as "won't fix" and close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants