Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/apply markdown (#130) #172

Merged
merged 5 commits into from
Dec 16, 2020
Merged

Feat/apply markdown (#130) #172

merged 5 commits into from
Dec 16, 2020

Conversation

bell-won
Copy link
Collaborator

@bell-won bell-won commented Dec 15, 2020 •
edited
Loading

Linked Issue

close #130
close #174

공유할 사항

  • 메시지 입력 시 markdown이 적용된 채로 db에 저장되기 때문에 메시지를 rendering 할 때에도 처리해줘야 할 부분이 생겼습니다. 마크다운이 적용되기 이전의 메시지는 error가 발생하기 때문에 db에서 chat, reply 를 한번 지워야 할 것 같습니다 🤦‍♂️

논의할 사항

  • 없습니다. ❌

@bell-won bell-won self-assigned this Dec 15, 2020
rockpell
rockpell approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@rockpell rockpell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Changyu-Ryou
Changyu-Ryou approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@Changyu-Ryou Changyu-Ryou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. draft js가 에디터 만들때 좋은 것 같아 보이네요

@bell-won bell-won merged commit d4a1056 into dev Dec 16, 2020
@bell-won bell-won deleted the feat/apply-markdown branch December 16, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Changyu-Ryou Changyu-Ryou Changyu-Ryou approved these changes

@rockpell rockpell rockpell approved these changes

Assignees

@bell-won bell-won

Labels
기능추가 버그수정
Projects
None yet
Milestone
No milestone
3 participants
@bell-won @rockpell @Changyu-Ryou