We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost/iostreams/filter/gzip.hpp, line 551: BOOST_ASSERT(!"Bad state");
BOOST_ASSERT(!"Bad state");
This line triggers a -Wstring-conversion warning:
boost/iostreams/filter/gzip.hpp:551:31: warning: implicit conversion turns string literal into bool: 'const char[10]' to 'bool' [-Wstring-conversion]
Would it be possible to use BOOST_ASSERT_MSG(false,"Bad state"); instead?
BOOST_ASSERT_MSG(false,"Bad state");
This would make it easier to enable the warning in projects that use Boost.IOStreams.
Btw: Most Boost code uses BOOST_ASSERT_MSG() nowadays (240 hits), the use of BOOST_ASSERT(!...) is not widespread (only 9 hits).
BOOST_ASSERT_MSG()
BOOST_ASSERT(!...)
The text was updated successfully, but these errors were encountered:
No branches or pull requests
boost/iostreams/filter/gzip.hpp, line 551:
BOOST_ASSERT(!"Bad state");This line triggers a -Wstring-conversion warning:
Would it be possible to use
BOOST_ASSERT_MSG(false,"Bad state");instead?This would make it easier to enable the warning in projects that use Boost.IOStreams.
Btw: Most Boost code uses
BOOST_ASSERT_MSG()nowadays (240 hits), the use ofBOOST_ASSERT(!...)is not widespread (only 9 hits).The text was updated successfully, but these errors were encountered: