Make operator-> const

Sébastien Gonzalve · Sébastien Gonzalve · commit 733e91957015 · 2024-11-10T17:47:31.000+01:00
Having this operator non-const is awkward as operator* is const. This
sometimes leads to writing:
  (*obj).data; instead of obj-&gt;data;
which is unexpected....
diff --git a/gtsam/nonlinear/Values.h b/gtsam/nonlinear/Values.h
@@ -189,7 +189,7 @@ namespace gtsam {
       const_iterator_type it_;
       deref_iterator(const_iterator_type it) : it_(it) {}
       ConstKeyValuePair operator*() const { return {it_->first, *(it_->second)}; }
-      std::unique_ptr<ConstKeyValuePair> operator->() {
+      std::unique_ptr<ConstKeyValuePair> operator->() const {
         return std::make_unique<ConstKeyValuePair>(it_->first, *(it_->second));
       }
       bool operator==(const deref_iterator& other) const {

Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ namespace gtsam {`
`189`	`189`	`const_iterator_type it_;`
`190`	`190`	`deref_iterator(const_iterator_type it) : it_(it) {}`
`191`	`191`	`ConstKeyValuePair operator() const { return {it_->first, (it_->second)}; }`
`192`		`- std::unique_ptr<ConstKeyValuePair> operator->() {`
	`192`	`+ std::unique_ptr<ConstKeyValuePair> operator->() const {`
`193`	`193`	`return std::make_unique<ConstKeyValuePair>(it_->first, *(it_->second));`
`194`	`194`	`}`
`195`	`195`	`bool operator==(const deref_iterator& other) const {`