From e19433c46f4a112efc0a81904dbdabd9aa789324 Mon Sep 17 00:00:00 2001
From: "Jacob V. Rasmussen" <black@blackthorne.dk>
Date: Wed, 19 Nov 2025 20:08:01 +0100
Subject: [PATCH] Remove name and email from expense and revenue lists

This aligns all printouts of user real names.
Some instances printed the email and some the UUID.
The detail pages now always prints the real name, and the UUID.
If the user does not have a real name, the UUID is shown as a fallback option, instead of presenting an empty cell.
All real names have been removed from the economy app, and will only be shown in the backoffice app.
---
 .../templates/includes/expense_detail_panel.html | 12 +++++++-----
 .../templates/includes/expense_list_panel.html   | 16 ++++++++++------
 .../includes/reimbursement_detail_panel.html     |  4 ++--
 .../templates/includes/revenue_detail_panel.html | 10 ++++++----
 .../templates/includes/revenue_list_panel.html   |  8 ++++++--
 5 files changed, 31 insertions(+), 19 deletions(-)

diff --git a/src/economy/templates/includes/expense_detail_panel.html b/src/economy/templates/includes/expense_detail_panel.html
index c525a3447..8034228e1 100644
--- a/src/economy/templates/includes/expense_detail_panel.html
+++ b/src/economy/templates/includes/expense_detail_panel.html
@@ -2,10 +2,12 @@
   <div class="card-header">Expense Details for {{ expense.pk }}</div>
   <div class="card-body">
     <table class="table">
-      <tr>
-        <th>Created By</th>
-        <td>{{ expense.user.profile.get_name }}</td>
-      </tr>
+      {% if request.resolver_match.app_name == "backoffice" %}
+        <tr>
+          <th>Created By</th>
+          <td>{{ expense.user.profile.get_name }}</td>
+        </tr>
+      {% endif %}
       <tr>
         <th>Amount</th>
         <td>{{ expense.amount }} DKK</td>
@@ -28,7 +30,7 @@
       </tr>
       <tr>
         <th>Paid by BornHack?</th>
-        <td>This expense was paid by {% if expense.paid_by_bornhack %}<b>BornHack</b>{% else %}<b>{{ expense.user.profile.get_name }}</b>, and will be reimbursed.{% endif %}</td>
+        <td>This expense was paid by {% if expense.paid_by_bornhack %}<b>BornHack</b>{% elif request.resolver_match.app_name == "backoffice" %}<b>{{ expense.user.profile.get_name }}</b>, and will be reimbursed.{% else %}the creator of the expense{% endif %}</td>
       </tr>
       <tr>
         <th>Filename</th>
diff --git a/src/economy/templates/includes/expense_list_panel.html b/src/economy/templates/includes/expense_list_panel.html
index 31767e7b7..6ed214a52 100644
--- a/src/economy/templates/includes/expense_list_panel.html
+++ b/src/economy/templates/includes/expense_list_panel.html
@@ -8,9 +8,11 @@
             <th>Camp</th>
         {% endif %}
         <th>Invoice Date</th>
-        <th>Created By</th>
-        {% if not reimbursement %}
-          <th>Paid by</th>
+        {% if request.resolver_match.app_name == "backoffice" %}
+          <th>Created By</th>
+          {% if not reimbursement %}
+            <th>Paid by</th>
+          {% endif %}
         {% endif %}
         <th>Creditor</th>
         <th>Amount</th>
@@ -34,9 +36,11 @@
           <td data-order="{{ expense.camp.title|sortable }}">{{ expense.camp.title }}</td>
           {% endif %}
           <td data-order="{{ expense.invoice_date|sortable }}">{{ expense.invoice_date }}</td>
-          <td>{{ expense.user.profile.get_name }}</td>
-          {% if not reimbursement %}
-            <td>{% if expense.paid_by_bornhack %}BornHack{% else %}{{ expense.user.profile.get_name }}{% endif %}</td>
+          {% if request.resolver_match.app_name == "backoffice" %}
+            <td>{{ expense.user.profile.get_name }}</td>
+            {% if not reimbursement %}
+              <td>{% if expense.paid_by_bornhack %}BornHack{% else %}{{ expense.user.profile.get_name }}{% endif %}</td>
+            {% endif %}
           {% endif %}
           <td>{{ expense.creditor.name }}</td>
           <td data-order="{{ expense.amount }}">{{ expense.amount }} DKK</td>
diff --git a/src/economy/templates/includes/reimbursement_detail_panel.html b/src/economy/templates/includes/reimbursement_detail_panel.html
index 3b2f05963..5c769d345 100644
--- a/src/economy/templates/includes/reimbursement_detail_panel.html
+++ b/src/economy/templates/includes/reimbursement_detail_panel.html
@@ -5,11 +5,11 @@
     <table class="table">
       <tr>
         <th>Reimbursement User</th>
-        <td>{{ reimbursement.reimbursement_user }}</td>
+        <td>{{ reimbursement.reimbursement_user.profile.get_name }}</td>
       </tr>
       <tr>
         <th>Created By</th>
-        <td>{{ reimbursement.user }}</td>
+        <td>{{ reimbursement.user.profile.get_name }}</td>
       </tr>
       <tr>
         <th>Total Amount</th>
diff --git a/src/economy/templates/includes/revenue_detail_panel.html b/src/economy/templates/includes/revenue_detail_panel.html
index f80d9bc63..39350e108 100644
--- a/src/economy/templates/includes/revenue_detail_panel.html
+++ b/src/economy/templates/includes/revenue_detail_panel.html
@@ -2,10 +2,12 @@
   <div class="card-header">Revenue Details for {{ revenue.pk }}</div>
   <div class="card-body">
     <table class="table">
-      <tr>
-        <th>Created By</th>
-        <td>{{ revenue.user }}</td>
-      </tr>
+      {% if request.resolver_match.app_name == "backoffice" %}
+        <tr>
+          <th>Created By</th>
+          <td>{{ revenue.user.profile.get_name }}</td>
+        </tr>
+      {% endif %}
       <tr>
         <th>Amount</th>
         <td>{{ revenue.amount }} DKK</td>
diff --git a/src/economy/templates/includes/revenue_list_panel.html b/src/economy/templates/includes/revenue_list_panel.html
index 1ce389265..702766aee 100644
--- a/src/economy/templates/includes/revenue_list_panel.html
+++ b/src/economy/templates/includes/revenue_list_panel.html
@@ -8,7 +8,9 @@
             <th>Camp</th>
         {% endif %}
         <th>Invoice Date</th>
-        <th>Created By</th>
+        {% if request.resolver_match.app_name == "backoffice" %}
+          <th>Created By</th>
+        {% endif %}
         <th>Debtor</th>
         <th>Amount</th>
         <th>Description</th>
@@ -25,7 +27,9 @@
           <td data-order="{{ revenue.camp.title|sortable }}">{{ revenue.camp.title }}</td>
           {% endif %}
           <td data-order="{{ revenue.invoice_date|sortable }}">{{ revenue.invoice_date }}</td>
-          <td>{{ revenue.user.email }}</td>
+          {% if request.resolver_match.app_name == "backoffice" %}
+            <td>{{ revenue.user.profile.get_name }}</td>
+          {% endif %}
           <td>{{ revenue.debtor }}</td>
           <td data-order="{{ revenue.amount }}">{{ revenue.amount }} DKK</td>
           <td>{{ revenue.description }}</td>