Skip to content

Commit b3ff013

Browse files
Kiran Gowda Kempannatimrulebosch
andcommitted
Correct misidentification of Container PDUs.
Co-authored-by: Rule Timothy <rut6abt@bosch.com> Signed-off-by: Rule Timothy (VM/EMT3) <Timothy.Rule@de.bosch.com>
1 parent 4ec7823 commit b3ff013

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

extra/tools/network/build/package/gencode.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,7 @@ def scan_messages(dbc_file, out_path, filter, cycle_time):
3838
for message in db.messages:
3939
if filter is not None and str(message.frame_id) in filter:
4040
continue
41-
isContainer = False
42-
if len(message.signal_groups) > 0 :
43-
isContainer = True
41+
isContainer = message.is_multiplexed()
4442
messageName = camel_to_snake_case(message.name)
4543
frames[messageName] = {
4644
'frame_id': int(message.frame_id),
@@ -52,7 +50,7 @@ def scan_messages(dbc_file, out_path, filter, cycle_time):
5250
}
5351
if str(message.frame_id) in cycle_time.keys():
5452
frames[messageName]['cycle_time_ms'] = int(cycle_time[str(message.frame_id)])
55-
if isContainer :
53+
if isContainer:
5654
for mux_id, signals in message.signal_tree[0]['Header_ID'].items():
5755
frames[messageName + '_' + hex(mux_id)] = {
5856
'container': messageName,

extra/tools/network/internal/app/generate/network.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,9 @@ func (c *GenNetworkCommand) Run() error {
108108
annotations["cycle_time_ms"] = frameInfo.CycleTime
109109
}
110110
}
111+
if frameInfo == nil {
112+
continue
113+
}
111114
annotations["struct_name"] = structName
112115
// Signals (field/member names of the struct).
113116
signals := []kind.NetworkSignal{}

0 commit comments

Comments
 (0)