Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop redirecting stderr when calling credential_process #2090

Closed
itsdalmo opened this issue Jun 29, 2020 · 1 comment
Closed

Stop redirecting stderr when calling credential_process #2090

itsdalmo opened this issue Jun 29, 2020 · 1 comment
Labels
feature-request This issue requests a feature. needs-triage This issue or PR still needs to be triaged.

Comments

@itsdalmo
Copy link

Is your feature request related to a problem? Please describe.
Currently, when resolving credentials using a credential_process you read both stdout and stderr. This means that the credential_process itself has no way of communicating with the user, which would be very useful to e.g. request user input (passwords, MFA tokens etc) or simply to provide debug logging.

Describe the solution you'd like
I would like remove the redirection of stderr and let the credential_process communicate directly to the user via the console, which is exactly whats done in v1 and v2 of the AWS SDK for Go.

@itsdalmo itsdalmo added feature-request This issue requests a feature. needs-triage This issue or PR still needs to be triaged. labels Jun 29, 2020
itsdalmo pushed a commit to telia-oss/botocore that referenced this issue Jun 29, 2020
…oto#2090)

Co-authored-by: Rickard Löfström <rickard.lofstrom@gmail.com>
@itsdalmo
Copy link
Author

Closing because it is a duplicate of #1348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue requests a feature. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

1 participant