Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support urllib3 2.1.0 and 2.2.0 to be installed #3112

Closed
2 tasks
matejsp opened this issue Feb 3, 2024 · 2 comments
Closed
2 tasks

Support urllib3 2.1.0 and 2.2.0 to be installed #3112

matejsp opened this issue Feb 3, 2024 · 2 comments
Assignees
Labels
dependencies This issue is a problem in a dependency. duplicate This issue is a duplicate. feature-request This issue requests a feature. p3 This is a minor priority issue

Comments

@matejsp
Copy link

matejsp commented Feb 3, 2024

Describe the feature

There is a new version of urllib3 (v2.2.0, v2.1.9) that can't be installed in projects that use botocore because, in the setup.py file, it has the version restriction:

urllib3>=1.25.4,<2.1; python_version>="3.10"

Use Case

urllib3 getting http/2 support (basic for now).

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

1.34.34

Environment details (OS name and version, etc.)

MacOSX Sonoma

@matejsp matejsp added feature-request This issue requests a feature. needs-triage This issue or PR still needs to be triaged. labels Feb 3, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK self-assigned this Feb 8, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK added duplicate This issue is a duplicate. dependencies This issue is a problem in a dependency. p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Feb 8, 2024
@RyanFitzSimmonsAK
Copy link
Contributor

Hi @iherasymenko, thanks for reaching out. According to the main tracking thread for the urllib3 pin, urllib3 2.1.x+ contains several breaking changes.

#2926 (comment)

We're currently pinned at urllib3<2.1 since it will contain a handful of breaking changes.

I'm going to close this issue as a duplicate in favor of the main tracking thread, which you can refer to for any updates regarding the urllib3 pin.

@RyanFitzSimmonsAK RyanFitzSimmonsAK closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies This issue is a problem in a dependency. duplicate This issue is a duplicate. feature-request This issue requests a feature. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

2 participants