Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Agent 2.0, second attempt #2977

Merged
merged 16 commits into from
Jun 30, 2023
Merged

User Agent 2.0, second attempt #2977

merged 16 commits into from
Jun 30, 2023

Conversation

jonemo
Copy link
Contributor

@jonemo jonemo commented Jun 28, 2023

#2955 was rolled back in #2976 because some libraries, including our very own s3transfer, expect client.meta.config.user_agent to contain the resolved user agent string (not the user agent string provided by the user in the original Config object). To minimize disruption to third party libraries, this PR updates the code formerly merged in #2955 to maintain this behavior.

Only the last two commits on this branch are new. All others have previously been part of #2955. You can use this link to only see the newly added changes.

@jonemo jonemo requested a review from nateprewitt June 28, 2023 00:29
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Patch coverage: 94.15% and project coverage change: +0.02 🎉

Comparison is base (8bd1a4d) 93.29% compared to head (c869fb6) 93.32%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2977      +/-   ##
===========================================
+ Coverage    93.29%   93.32%   +0.02%     
===========================================
  Files           64       65       +1     
  Lines        13588    13764     +176     
===========================================
+ Hits         12677    12845     +168     
- Misses         911      919       +8     
Impacted Files Coverage Δ
botocore/config.py 100.00% <ø> (ø)
botocore/configprovider.py 94.09% <ø> (ø)
botocore/session.py 97.64% <80.00%> (+0.74%) ⬆️
botocore/client.py 97.67% <83.33%> (-0.18%) ⬇️
botocore/useragent.py 94.92% <94.92%> (ø)
botocore/args.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonemo jonemo merged commit b64043a into boto:develop Jun 30, 2023
31 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Jul 3, 2023
* release-1.30.0:
  Bumping version to 1.30.0
  Update to latest partitions and endpoints
  Update to latest models
  User Agent 2.0, second attempt (#2977)
dlm6693 pushed a commit to dlm6693/botocore that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants