Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GHA configurations #2989

Merged
merged 3 commits into from
Jul 22, 2023
Merged

Update GHA configurations #2989

merged 3 commits into from
Jul 22, 2023

Conversation

nateprewitt
Copy link
Contributor

This PR adds:

  • Explicit scoping for token usage in our existing workflows.
  • Updates close-stale-issues to only run once a day to save worker resources.
  • Adds CodeQL to run static analysis over code base.

security-events: write
steps:
- name: "Checkout repository"
uses: "actions/checkout@8f4b7f84864484a7bf31766abe9204da3cbe65b3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this specific hash? Same question for the ones below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to add another commit to move everything to pins. I have the end result in the S3transfer PR.

The main goal is to ensure that we're always using a known state when running actions. That means if a repository is compromised and a new commit with malicious code is made under a known tag, we don't run the malicious code. The ability to compromise a repository and rewrite the history to create the same commit hash is almost impossible.

Full information can be found here: https://github.com/ossf/scorecard/blob/e1eede2d3fa09d08bbc00ca2331c2bffebdc602d/docs/checks.md#pinned-dependencies

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@jonathan343 jonathan343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the new CodeQL job passed👍

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (104226d) 93.36% compared to head (28bd007) 93.36%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2989   +/-   ##
========================================
  Coverage    93.36%   93.36%           
========================================
  Files           65       65           
  Lines        13841    13841           
========================================
  Hits         12923    12923           
  Misses         918      918           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nateprewitt nateprewitt merged commit a47126b into boto:develop Jul 22, 2023
64 checks passed
@nateprewitt nateprewitt deleted the GHA_updates branch July 22, 2023 00:23
aws-sdk-python-automation added a commit that referenced this pull request Jul 24, 2023
* release-1.31.10:
  Bumping version to 1.31.10
  Update to latest partitions and endpoints
  Update to latest models
  Update quicksight sdk extras paginators
  Update GHA configurations (#2989)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants