Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add paginator for opensearch #3246

Closed
wants to merge 1 commit into from

Conversation

digglife
Copy link

@digglife digglife commented Sep 5, 2024

With this change, we can use paginator for the OpenSearch APIs with Max Results limit, instead of looping with NextToken manually.

# a trivial example
instances = []
opensearch = boto3.client('opensearch')
paginator = opensearch.get_paginator('describe_reserved_instances')
for page in paginator.paginate():
    instances.extend(page['ReservedInstances'])

fixes: #3245

With this change, we can use paginator for the OpenSearch APIs with Max
Results limit, instead of looping with NextToken manually.

fixes: boto#3245
@tim-finnigan
Copy link
Contributor

Thanks for creating this PR, but we can't accept these changes for reasons described in #3245 (comment)

@digglife digglife deleted the opensearch-paginator branch September 27, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Paginator For OpenSearch Client
2 participants