Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Modified bug issue template to add checkbox to report potential regression. #3250

Conversation

ashishdhingra
Copy link
Contributor

  • Modified bug issue template to add checkbox to report potential regression.
  • Added GitHub action to add/remove label potential-regression when issue is created/edited.

NOTE:

  • The GitHub action code was ported from CDK repo.
  • The label potential-regression would need to be created manually (we could use color #FF6700 and description Marking this issue as a potential regression to be checked by team member to make it consistent across SDK repos)

Label potential-regression would make issue standout in the list and help engineers to triage potential high severity issues effectively.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple quick fixes to make sure we're not regressing OSSF scores and we can look at merging.

steps:
- name: Fetch template body
id: check_regression
uses: actions/github-script@v7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's pin it to the specific release SHA instead of a tag.

Suggested change
uses: actions/github-script@v7
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nateprewitt I guess the commit corresponds to v7.0.1. Should we instead change it to actions/github-script@v7.0.1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both v7 and v7.0.1 are the same commit. This may have been an error on their side.

The issue we're controlling for is supply chain attacks where someone gets access to a repo, deletes an existing tag, and replaces it pointing to another commit. All of our workflows use exact SHAs to prevent this and we should maintain that in any new workflow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're interested in more information, you can read the guidance for this specific issue here. There are also a few resources describing the ossf scorecard at a high level if interested [blog] [readme].

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ashishdhingra! Can we get these changes moved to the boto3/cli versions of these PRs as well?

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (e0f04ab) to head (0e229ae).
Report is 118 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3250      +/-   ##
===========================================
+ Coverage    93.15%   93.17%   +0.02%     
===========================================
  Files           66       66              
  Lines        14287    14339      +52     
===========================================
+ Hits         13309    13361      +52     
  Misses         978      978              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashishdhingra
Copy link
Contributor Author

Looks good, thanks @ashishdhingra! Can we get these changes moved to the boto3/cli versions of these PRs as well?

@nateprewitt Done for other PR(s) as well:

Please review. Also help them merge since I do not have permissions to do so.

Thanks,
Ashish

@nateprewitt nateprewitt merged commit f54eb24 into boto:develop Sep 26, 2024
34 checks passed
@ashishdhingra ashishdhingra deleted the user/ashdhin/IssueTemplateRegressionCheckbox branch September 27, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants