Skip to content

Commit 623d406

Browse files
committed
Revert "escape name and id of entities"
This reverts commit 1584155.
1 parent 1584155 commit 623d406

File tree

1 file changed

+2
-18
lines changed

1 file changed

+2
-18
lines changed

cli/lib/api.go

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import (
1919
"io"
2020
"math/rand"
2121
"net/http"
22-
"net/url"
2322
"os"
2423
"slices"
2524
"strconv"
@@ -328,24 +327,9 @@ func Startup(ctx context.Context, js jetstream.JetStream, logger *zap.Logger, po
328327
}
329328

330329
vars := mux.Vars(request)
331-
332-
// url decode the name
333-
escapedName, err := url.QueryUnescape(vars["name"])
334-
if err != nil {
335-
http.Error(writer, "Internal Server Error", http.StatusInternalServerError)
336-
logger.Error("Failed to url decode name", zap.Error(err))
337-
return
338-
}
339-
escapedId, err := url.QueryUnescape(vars["id"])
340-
if err != nil {
341-
http.Error(writer, "Internal Server Error", http.StatusInternalServerError)
342-
logger.Error("Failed to url decode id", zap.Error(err))
343-
return
344-
}
345-
346330
id := &glue.EntityId{
347-
Name: escapedName,
348-
Id: escapedId,
331+
Name: strings.TrimSpace(vars["name"]),
332+
Id: strings.TrimSpace(vars["id"]),
349333
}
350334

351335
ctx := getCorrelationId(ctx, &request.Header, nil)

0 commit comments

Comments
 (0)