Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move global data and node selector out of the bpfcommon data struct #17

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jun 3, 2024

preq before defining new application CRD

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 48.79518% with 85 lines in your changes missing coverage. Please review.

Project coverage is 26.36%. Comparing base (768a235) to head (691a9cd).
Report is 3 commits behind head on main.

Files Patch % Lines
apis/v1alpha1/zz_generated.deepcopy.go 48.17% 69 Missing and 2 partials ⚠️
controllers/bpfman-agent/fentry-program.go 50.00% 2 Missing ⚠️
controllers/bpfman-agent/fexit-program.go 50.00% 2 Missing ⚠️
controllers/bpfman-agent/kprobe-program.go 50.00% 2 Missing ⚠️
controllers/bpfman-agent/tc-program.go 50.00% 2 Missing ⚠️
controllers/bpfman-agent/tracepoint-program.go 50.00% 2 Missing ⚠️
controllers/bpfman-agent/uprobe-program.go 50.00% 2 Missing ⚠️
controllers/bpfman-agent/xdp-program.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   26.38%   26.36%   -0.02%     
==========================================
  Files          75       75              
  Lines        5021     5112      +91     
==========================================
+ Hits         1325     1348      +23     
- Misses       3532     3600      +68     
  Partials      164      164              
Flag Coverage Δ
unittests 26.36% <48.79%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

// NodeSelector allows the user to specify which nodes to deploy the
// bpf program to. This field must be specified, to select all nodes
// use standard metav1.LabelSelector semantics and make it empty.
NodeSelector metav1.LabelSelector `json:"nodeselector"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you didn't put these in a common struct in shared_types.go?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@@ -149,11 +149,13 @@ spec:
items:
type: string
type: array
x-kubernetes-list-type: atomic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you do anything to cause this to change, or did it just happen when you regenerated the crds?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly due to an update in the tools. I think that's the default anyway.

Copy link
Contributor

@anfredette anfredette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anfredette anfredette merged commit 96ce268 into bpfman:main Jun 4, 2024
7 checks passed
msherif1234 pushed a commit to msherif1234/bpfman-operator that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants