-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move global data and node selector out of the bpfcommon data struct #17
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
- Coverage 26.38% 26.36% -0.02%
==========================================
Files 75 75
Lines 5021 5112 +91
==========================================
+ Hits 1325 1348 +23
- Misses 3532 3600 +68
Partials 164 164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apis/v1alpha1/kprobeProgram_types.go
Outdated
// NodeSelector allows the user to specify which nodes to deploy the | ||
// bpf program to. This field must be specified, to select all nodes | ||
// use standard metav1.LabelSelector semantics and make it empty. | ||
NodeSelector metav1.LabelSelector `json:"nodeselector"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you didn't put these in a common struct in shared_types.go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@@ -149,11 +149,13 @@ spec: | |||
items: | |||
type: string | |||
type: array | |||
x-kubernetes-list-type: atomic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you do anything to cause this to change, or did it just happen when you regenerated the crds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly due to an update in the tools. I think that's the default anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update Konflux references
preq before defining new application CRD