Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better approach for PRs from forks (workflow commands via stdout) #59

Open
jnm2 opened this issue Mar 31, 2021 · 1 comment
Open

A better approach for PRs from forks (workflow commands via stdout) #59

jnm2 opened this issue Mar 31, 2021 · 1 comment

Comments

@jnm2
Copy link

jnm2 commented Mar 31, 2021

If you write workflow commands to stdout instead of making web API calls which depend on the token, the authentication issue mentioned at https://github.com/bradennapier/eslint-plus-action#handle-forked-prs goes away and the performance may even be better.

Example from docs page (https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message):

echo "::warning file=app.js,line=1,col=5::Missing semicolon"

Both warning and error inline annotations can be created this way. A GitHub action using this approach: https://github.com/cschleiden/jest-github-actions-reporter

@bradennapier
Copy link
Owner

Yes that is new -- this was made back when they didn't have support for actions in forked repos so a lot of the craziness is built around a method i found to make it work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants