From c51038fab6d6fffd736f26f80467bb1dd9b73a4a Mon Sep 17 00:00:00 2001
From: Greg Royal <groyal@caci.com>
Date: Wed, 12 Dec 2018 16:13:37 -0700
Subject: [PATCH 1/2] fix(punyparent): fixed puny parent to debounce on change

---
 src/os/ui/help/help.js       |  2 +-
 src/os/ui/util/punyparent.js | 58 +++++++++++++++++++++++-------------
 2 files changed, 39 insertions(+), 21 deletions(-)

diff --git a/src/os/ui/help/help.js b/src/os/ui/help/help.js
index 50be4caed..10f5af8b1 100644
--- a/src/os/ui/help/help.js
+++ b/src/os/ui/help/help.js
@@ -59,7 +59,7 @@ os.ui.help.helpDirective = function() {
     scope: true,
     controller: os.ui.help.HelpCtrl,
     controllerAs: 'ctrl',
-    template: '<button class="btn btn-info dropdown-toggle" title="Support"' +
+    template: '<button class="btn btn-info" ng-class="{\'dropdown-toggle\': !puny}" title="Support"' +
         ' ng-click="ctrl.openMenu()" ng-right-click="ctrl.openMenu()" ng-class="{active: menu}">' +
         '<i class="fa fa-question-circle" ng-class="{\'fa-fw\': puny}"></i> ' +
         '<span ng-class="{\'d-none\': puny}">Support</span>' +
diff --git a/src/os/ui/util/punyparent.js b/src/os/ui/util/punyparent.js
index 09f83c381..9a1975b02 100644
--- a/src/os/ui/util/punyparent.js
+++ b/src/os/ui/util/punyparent.js
@@ -1,5 +1,6 @@
 goog.provide('os.ui.util.PunyParentCtrl');
 goog.provide('os.ui.util.punyParentDirective');
+goog.require('goog.async.Debouncer');
 goog.require('os.ui.Module');
 
 
@@ -42,6 +43,13 @@ os.ui.util.PunyParentCtrl = function($scope, $element) {
    */
   this.element_ = $element;
 
+  /**
+   * Used to delay searching until we are done typing
+   * @type {goog.async.Debouncer}
+   * @private
+   */
+  this.debounce_ = new goog.async.Debouncer(this.onDebouncedResize_, 200, this);
+
   /**
    * @type {Function}
    * @private
@@ -74,27 +82,37 @@ os.ui.util.PunyParentCtrl.prototype.destroy_ = function() {
  * @private
  */
 os.ui.util.PunyParentCtrl.prototype.onResize_ = function() {
-  var children = this.element_.children().toArray();
-  var childrenWidth = 0;
-  children.forEach(function(child) {
-    var c = $(child);
-    // ignore the resize trigger since thats the parent size
-    if (!c.hasClass('resize-triggers')) {
-      childrenWidth += c.outerWidth(true);
-    }
-  });
+  this.debounce_.fire();
+};
 
-  if (childrenWidth > this.fullSize) {
-    this.fullSize = childrenWidth;
-  }
 
-  // Set the puny state on the child scope
-  children.forEach(function(child) {
-    var c = $(child);
-    var cscope = c.scope();
-    if (!c.hasClass('resize-triggers') && cscope) {
-      cscope['puny'] = this.element_.outerWidth(true) < this.fullSize;
+/**
+ * @private
+ */
+os.ui.util.PunyParentCtrl.prototype.onDebouncedResize_ = function() {
+  if (this.element_) {
+    var children = this.element_.children().toArray();
+    var childrenWidth = 0;
+    children.forEach(function(child) {
+      var c = $(child);
+      // ignore the resize trigger since thats the parent size
+      if (!c.hasClass('resize-triggers')) {
+        childrenWidth += c.outerWidth(true);
+      }
+    });
+
+    if (childrenWidth > this.fullSize) {
+      this.fullSize = childrenWidth;
     }
-  }.bind(this));
-  os.ui.apply(this.scope_);
+
+    // Set the puny state on the child scope
+    children.forEach(function(child) {
+      var c = $(child);
+      var cscope = c.scope();
+      if (!c.hasClass('resize-triggers') && cscope) {
+        cscope['puny'] = this.element_.outerWidth(true) < this.fullSize;
+      }
+    }.bind(this));
+    os.ui.apply(this.scope_);
+  }
 };

From d5322dd24c94ba4d9eff16b59b2eb5438bd4c159 Mon Sep 17 00:00:00 2001
From: Greg Royal <groyal@caci.com>
Date: Fri, 21 Dec 2018 14:28:04 -0700
Subject: [PATCH 2/2] fix(punyparent): fixed glitchyness

---
 src/os/ui/util/punyparent.js | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/os/ui/util/punyparent.js b/src/os/ui/util/punyparent.js
index 9a1975b02..8ba7a1a96 100644
--- a/src/os/ui/util/punyparent.js
+++ b/src/os/ui/util/punyparent.js
@@ -1,6 +1,6 @@
 goog.provide('os.ui.util.PunyParentCtrl');
 goog.provide('os.ui.util.punyParentDirective');
-goog.require('goog.async.Debouncer');
+goog.require('goog.Throttle');
 goog.require('os.ui.Module');
 
 
@@ -45,10 +45,10 @@ os.ui.util.PunyParentCtrl = function($scope, $element) {
 
   /**
    * Used to delay searching until we are done typing
-   * @type {goog.async.Debouncer}
+   * @type {goog.Throttle}
    * @private
    */
-  this.debounce_ = new goog.async.Debouncer(this.onDebouncedResize_, 200, this);
+  this.throttle_ = new goog.Throttle(this.onThrottleResize_, 200, this);
 
   /**
    * @type {Function}
@@ -73,6 +73,10 @@ os.ui.util.PunyParentCtrl = function($scope, $element) {
  */
 os.ui.util.PunyParentCtrl.prototype.destroy_ = function() {
   this.element_.removeResize(this.resizeFn_);
+  if (this.throttle_) {
+    this.throttle_.dispose();
+    this.throttle_ = null;
+  }
   this.scope_ = null;
   this.element_ = null;
 };
@@ -82,14 +86,14 @@ os.ui.util.PunyParentCtrl.prototype.destroy_ = function() {
  * @private
  */
 os.ui.util.PunyParentCtrl.prototype.onResize_ = function() {
-  this.debounce_.fire();
+  this.throttle_.fire();
 };
 
 
 /**
  * @private
  */
-os.ui.util.PunyParentCtrl.prototype.onDebouncedResize_ = function() {
+os.ui.util.PunyParentCtrl.prototype.onThrottleResize_ = function() {
   if (this.element_) {
     var children = this.element_.children().toArray();
     var childrenWidth = 0;