Build: fix linux build #641

whatuserever · 2025-02-08T19:28:47Z

Fixes #640: Linux build was failing due to icon. It doesn't seem to work with ics or ico formats, or at least not the ones which are used for Mac/Windows.
To mitigate, set a png icon.

Note that for some reason the icon does not seem to actually apply:

I thought it might be due to the png dimensions, but I tried setting a 512x512 png instead and the result was the same.

Summary by CodeRabbit

New Features
- Updated the Linux application build with a fresh icon for enhanced visual branding.
Improvements
- Expanded the testing matrix to include Windows as an operating system for running tests.

coderabbitai · 2025-02-08T19:28:55Z

Walkthrough

The pull request updates the electron-builder configuration by adding an icon specification for the Linux build target. Specifically, the configuration now points to "packages/renderer/src/assets/logos/logoFishOnly.png" for the Linux build. Additionally, the GitHub Actions workflow for tests has been modified to include windows-latest in the operating system matrix, allowing tests to run on Windows.

Changes

File(s)	Change Summary
electron-builder.yml	Added Linux icon specification: `icon: packages/renderer/src/assets/logos/logoFishOnly.png`
.github/workflows/tests.yml	Uncommented entry for `windows-latest` in job `tests`, allowing tests to run on Windows.

Assessment against linked issues

Objective	Addressed	Explanation
Linux builds are failing (#640)	✅

Possibly related PRs

Fix: Set icon for app in windows and mac #596: Added icon specifications for macOS and Windows in electron-builder.yml, which relates to the Linux icon addition in this PR.

Suggested labels

released

Poem

I'm a hoppy bunny, code in tow,
Linux builds now shine and glow.
A little tweak, a little cheer,
Our icon's marked, the path is clear.
Hop on board and watch it go!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c06c05 and 580c7c9.

📒 Files selected for processing (1)

.github/workflows/tests.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: build (windows-latest)
GitHub Check: tests (windows-latest)
GitHub Check: build (macos-13)

🔇 Additional comments (2)

.github/workflows/tests.yml (2)

19-23: Add Windows Testing to OS Matrix
The inclusion of "windows-latest" in the operating system matrix is a useful enhancement to broaden the testing coverage across platforms. Ensure that any differences in behavior on Windows—especially regarding graphical environments and Electron window handling—are addressed in your tests, since the xvfb-run workaround applies only to Ubuntu.

38-44: Validate OS-Specific E2E Test Execution
The workflow correctly distinguishes between Ubuntu and non-Ubuntu environments for running end-to-end tests. Please verify that the non-Ubuntu branch (which now includes Windows) executes the tests as expected without requiring additional configuration for graphical interface simulation.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

baruchiro · 2025-02-08T19:59:50Z

Fron when the Linux tests are failing? Why I didn't notice it before?

Please check if you introduced any problem on the yarn test:e2e.

whatuserever · 2025-02-09T07:15:05Z

Fron when the Linux tests are failing? Why I didn't notice it before?

Huh, didn't even notice. Looking at the test action history, looks like it started with #636.

Please check if you introduced any problem on the yarn test:e2e.

yarn test:e2e seems to be successful on my machine:

 ✓ tests/e2e.spec.ts (2) 1509ms
   ✓ Main window state
   ✓ Main window web content

Same goes for yarn test.
Not sure why it's failing when run as part of the PR checks. Any idea what could be the difference?

whatuserever · 2025-02-09T07:33:38Z

Not sure why it's failing when run as part of the PR checks. Any idea what could be the difference?

Did some research and found the issue. Check out #643

# Conflicts: # .github/workflows/tests.yml

github-actions · 2025-02-11T05:42:48Z

🎉 This PR is included in version 2.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Fixes brafdlog#640: Linux build was failing due to icon. It doesn't seem to work with `ics` or `ico` formats, or at least not the ones which are used for Mac/Windows. To mitigate, set a png icon. Note that for some reason the icon does not seem to actually apply: ![image](https://github.com/user-attachments/assets/8be0db2d-8459-47fe-a712-e5db72761635) I thought it might be due to the png dimensions, but I tried setting a 512x512 png instead and the result was the same.  ## Summary by CodeRabbit - **New Features** - Updated the Linux application build with a fresh icon for enhanced visual branding. - **Improvements** - Expanded the testing matrix to include Windows as an operating system for running tests.  --------- Co-authored-by: Baruch Odem <baruchiro@gmail.com>

Fix: linux build

5c06c05

baruchiro approved these changes Feb 8, 2025

View reviewed changes

run tests on windows too

580c7c9

baruchiro mentioned this pull request Feb 9, 2025

Fix: Ubuntu GitHub test action #643

Merged

Merge remote-tracking branch 'origin/master' into linux_build

f21cdc7

# Conflicts: # .github/workflows/tests.yml

baruchiro approved these changes Feb 11, 2025

View reviewed changes

baruchiro changed the title ~~Fix: linux build~~ Build: fix linux build Feb 11, 2025

baruchiro merged commit 05b6b16 into brafdlog:master Feb 11, 2025
9 checks passed

github-actions bot added the released label Feb 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build: fix linux build #641

Build: fix linux build #641

whatuserever commented Feb 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 8, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

baruchiro commented Feb 8, 2025 •

edited

Loading

whatuserever commented Feb 9, 2025

whatuserever commented Feb 9, 2025

github-actions bot commented Feb 11, 2025

Build: fix linux build #641

Build: fix linux build #641

Conversation

whatuserever commented Feb 8, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Feb 8, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

baruchiro commented Feb 8, 2025 • edited Loading

whatuserever commented Feb 9, 2025

whatuserever commented Feb 9, 2025

github-actions bot commented Feb 11, 2025

whatuserever commented Feb 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

baruchiro commented Feb 8, 2025 •

edited

Loading