Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Circular dependency between imio and brainglobe-utils #64

Closed
17 tasks done
willGraham01 opened this issue Jan 31, 2024 · 1 comment · Fixed by brainglobe/brainglobe-meta#47
Closed
17 tasks done
Assignees
Labels
bug Something isn't working

Comments

@willGraham01
Copy link

willGraham01 commented Jan 31, 2024

brainglobe/brainglobe-utils#22 introduced a circular dependency between brainglobe-utils and imio: imio needs brainglobe-utils, whilst brainglobe-utils now needs imio due to the functionality that was refactored into it.

Needless to say, this is not ideal. On the surface everything "still works" since there are no circular imports, but naturally we probably want to fix this sooner rather than later.

Zulip discussion: https://brainglobe.zulipchat.com/#narrow/stream/408841-development/topic/.60imio.60.20and.20.60brainglobe-utils.60.20circular.20dependency/near/419020085

Task List (merge imio into brainglobe-utils)

@willGraham01 willGraham01 added the bug Something isn't working label Jan 31, 2024
@willGraham01
Copy link
Author

As agreed in the developer meeting on 08-02-2024, we will be merging imio into brainglobe-utils as a submodule.

Task list with updates has been added to the main issue comment for tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant