Skip to content

Commit 053f04c

Browse files
committed
[cr132][DanglingPtr] ComponentInstallerPolicy overstaying
`ComponentInstallerPolicy` instances are supposed to die during tests with `ComponentUpdateService`. However as `SequentialUpdateChecker` was taking references to these shared data, this was keeping the policies alive indefinetely, which was causing dangling pointer crashes in CI. This change temporarily filters these tests in particular: ComponentManagerUpdateCheckBrowserTest.RegisterAndUnregisterTranslateKitLanguagePackComponent ComponentManagerUpdateCheckBrowserTest.RegisterTranslateKitComponent We will fix this properly in a subsequent commit via brave/brave-browser#42532. Chromium change: https://chromium.googlesource.com/chromium/src/+/fa904be21056bca3dfa3e46a031af1e6787aef67 commit fa904be21056bca3dfa3e46a031af1e6787aef67 Author: Tsuyoshi Horo <horo@chromium.org> Date: Thu Oct 24 09:27:34 2024 +0000 Add a simple browser_test for Translator API. This CL introduces a new ComponentManager class which handles the TranslateKit component and the language pack components. And also this CL adds a simple browser test for Translator API by using a fake ComponentManager which can install a mock_translate_kit_lib and a fake language pack. Bug: 374631433
1 parent 52da61c commit 053f04c

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

test/filters/browser_tests.filter

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1931,6 +1931,11 @@
19311931
# This test fails because we stub out NetworkService::UpdateKeysPinList
19321932
-PKIMetadataComponentInstallerTest.InstallComponentUpdatesPinningConfig
19331933

1934+
# Temporarily disabled due to a dangling pointer issue in our update checker,
1935+
# identified here https://github.com/brave/brave-browser/issues/42532
1936+
-ComponentManagerUpdateCheckBrowserTest.RegisterAndUnregisterTranslateKitLanguagePackComponent
1937+
-ComponentManagerUpdateCheckBrowserTest.RegisterTranslateKitComponent
1938+
19341939
# Tests below this point have not been diagnosed or had issues created yet.
19351940
-_/WebrtcLoggingPrivateApiStartEventLoggingTestFeatureAndPolicyEnabled.*
19361941
-AccessCodeCastHandlerBrowserTest.*

0 commit comments

Comments
 (0)