You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
`ComponentInstallerPolicy` instances are supposed to die during tests
with `ComponentUpdateService`. However as `SequentialUpdateChecker` was
taking references to these shared data, this was keeping the policies
alive indefinetely, which was causing dangling pointer crashes in CI.
This change temporarily filters these tests in particular:
ComponentManagerUpdateCheckBrowserTest.RegisterAndUnregisterTranslateKitLanguagePackComponent
ComponentManagerUpdateCheckBrowserTest.RegisterTranslateKitComponent
We will fix this properly in a subsequent commit via
brave/brave-browser#42532.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/fa904be21056bca3dfa3e46a031af1e6787aef67
commit fa904be21056bca3dfa3e46a031af1e6787aef67
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Oct 24 09:27:34 2024 +0000
Add a simple browser_test for Translator API.
This CL introduces a new ComponentManager class which handles the
TranslateKit component and the language pack components.
And also this CL adds a simple browser test for Translator API by
using a fake ComponentManager which can install a mock_translate_kit_lib
and a fake language pack.
Bug: 374631433
0 commit comments