Skip to content

Commit 9f6e7b5

Browse files
Removes the "Account name" input field.
1 parent 588f333 commit 9f6e7b5

File tree

4 files changed

+0
-21
lines changed

4 files changed

+0
-21
lines changed

app/brave_settings_strings.grdp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,6 @@
7171
<message name="IDS_SETTINGS_BRAVE_ACCOUNT_EMAIL_INPUT_ERROR_MESSAGE" translateable="false" desc="Error message for when the user tries to use a @bravealias.com email address when creating their Brave Account">
7272
You can't use @bravealias.com addresses for creating Brave accounts. Please try again with a different domain.
7373
</message>
74-
<message name="IDS_SETTINGS_BRAVE_ACCOUNT_ACCOUNT_NAME_INPUT_LABEL" translateable="false" desc="Label for the 'Account name' input field">
75-
Account name
76-
</message>
77-
<message name="IDS_SETTINGS_BRAVE_ACCOUNT_ACCOUNT_NAME_INPUT_PLACEHOLDER" translateable="false" desc="Placeholder for the 'Account name' input field">
78-
Enter a name for your account
79-
</message>
8074
<message name="IDS_SETTINGS_BRAVE_ACCOUNT_CREATE_PASSWORD_INPUT_LABEL" translateable="false" desc="Label for the 'Create a password' input field">
8175
Create a password
8276
</message>

browser/resources/settings/getting_started_page/brave_account_create_dialog.html.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ export function getHtml(this: SettingsBraveAccountCreateDialogElement) {
3232
<div>$i18n{braveAccountEmailInputErrorMessage}</div>
3333
</div>
3434
</leo-input>
35-
<leo-input placeholder="$i18n{braveAccountAccountNameInputPlaceholder}"
36-
@input=${this.onAccountNameInput}>
37-
<div class="label">$i18n{braveAccountAccountNameInputLabel}</div>
38-
</leo-input>
3935
<leo-input placeholder="$i18n{braveAccountPasswordInputPlaceholder}"
4036
showErrors
4137
type="password"
@@ -85,7 +81,6 @@ export function getHtml(this: SettingsBraveAccountCreateDialogElement) {
8581
<div slot="buttons">
8682
<leo-button ?isDisabled=${!this.isEmailValid
8783
|| this.isEmailValid && this.isEmailBraveAlias
88-
|| !this.isAccountNameValid
8984
|| this.passwordStrength !== 100
9085
|| this.passwordConfirmation !== this.password
9186
|| !this.isCheckboxChecked}

browser/resources/settings/getting_started_page/brave_account_create_dialog.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ export class SettingsBraveAccountCreateDialogElement extends CrLitElement {
124124
static override get properties() {
125125
return {
126126
email: { type: String },
127-
isAccountNameValid: { type: Boolean },
128127
isCheckboxChecked: { type: Boolean },
129128
isEmailBraveAlias: { type: Boolean },
130129
isEmailValid: { type: Boolean },
@@ -140,10 +139,6 @@ export class SettingsBraveAccountCreateDialogElement extends CrLitElement {
140139
this.isEmailBraveAlias = (/@bravealias\.com$/i).test(this.email)
141140
}
142141

143-
protected onAccountNameInput(detail: { value: string }) {
144-
this.isAccountNameValid = detail.value.length !== 0
145-
}
146-
147142
protected onPasswordInput(detail: { value: string }) {
148143
this.password = detail.value
149144
this.browserProxy.getPasswordStrength(this.password).then(
@@ -176,7 +171,6 @@ export class SettingsBraveAccountCreateDialogElement extends CrLitElement {
176171
BraveAccountBrowserProxyImpl.getInstance()
177172
protected email: string = ''
178173
protected icon: string = 'warning-triangle-filled'
179-
protected isAccountNameValid: boolean = false
180174
protected isCheckboxChecked: boolean = false
181175
protected isEmailBraveAlias: boolean = false
182176
protected isEmailValid: boolean = false

browser/ui/webui/settings/brave_settings_localized_strings_provider.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,6 @@ void BraveAddCommonStrings(content::WebUIDataSource* html_source,
162162
IDS_SETTINGS_BRAVE_ACCOUNT_CREATE_DIALOG_DESCRIPTION},
163163
{"braveAccountEmailInputErrorMessage",
164164
IDS_SETTINGS_BRAVE_ACCOUNT_EMAIL_INPUT_ERROR_MESSAGE},
165-
{"braveAccountAccountNameInputLabel",
166-
IDS_SETTINGS_BRAVE_ACCOUNT_ACCOUNT_NAME_INPUT_LABEL},
167-
{"braveAccountAccountNameInputPlaceholder",
168-
IDS_SETTINGS_BRAVE_ACCOUNT_ACCOUNT_NAME_INPUT_PLACEHOLDER},
169165
{"braveAccountCreatePasswordInputLabel",
170166
IDS_SETTINGS_BRAVE_ACCOUNT_CREATE_PASSWORD_INPUT_LABEL},
171167
{"braveAccountPasswordStrengthMeterWeak",

0 commit comments

Comments
 (0)