Merge pull request #26470 from brave/bsc-fix-skus-unreached

bsclifton · web-flow · commit e35a9342fd47 · 2024-11-11T09:45:52.000-07:00
Update NOTREACHED in SKU SDK utils
diff --git a/components/skus/browser/skus_utils.cc b/components/skus/browser/skus_utils.cc
@@ -44,9 +44,7 @@ std::string GetDomain(const std::string& prefix,
     return prefix + ".brave.software";
   }
 
-  NOTREACHED_IN_MIGRATION();
-
-  return "";
+  NOTREACHED() << "Unsupported environment: " << environment;
 }
 
 std::string GetEnvironmentForDomain(const std::string& domain) {

Original file line number	Diff line number	Diff line change
`@@ -44,9 +44,7 @@ std::string GetDomain(const std::string& prefix,`
`44`	`44`	`return prefix + ".brave.software";`
`45`	`45`	`}`
`46`	`46`
`47`		`- NOTREACHED_IN_MIGRATION();`
`48`		`-`
`49`		`- return "";`
	`47`	`+ NOTREACHED() << "Unsupported environment: " << environment;`
`50`	`48`	`}`
`51`	`49`
`52`	`50`	`std::string GetEnvironmentForDomain(const std::string& domain) {`