-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No warnings for invalid syntax submissions #20
Comments
discard=
syntax
Hi @devidw, Thanks for opening this issue, that's great feedback! We'll look into it. Note, though that forbidding |
Hey @remusao Happy to hear that 🙂 When talking about these cases with multiple For example, taking this example:
Would this be interpreted as:
Or:
Or even differently? Perhaps escape characters for goggle syntax critical tokens could help here? |
Hi @devidw,
Would be interpreted as:
Not sure if escaping would help since it's not really expected for a Wdyt? |
@remusao alright, I see. In this case what I pointed out as error "Multiple $'s" would be indeed not an error at all but valid syntax. The only problematic situation I could image would be someone writing an instruction with multiple dollar signs and don't want to add options to it. If the last part of the pattern matches one option, it would not be interpreted as pattern, but rather as instruction. For example, if we want to write a pattern like:
And actually want to have it interpreted as The workaround would be to
This would not change the results since boost is the default behavior. And the final pattern would be the expected Perhaps it's even possible to add a single So something like a little hacky:
In case this works as described? Alternatively, escaping in the pattern could help, so there would be no need to add a tailing dollar sign.
But I don't know if it makes sense to implement escaping because of the possibly unnecessary complexity overload. |
Adding a |
I noticed that invalid syntax gets silently submitted without any warnings.
Would be great to get notified about these syntax issues in submitted goggles.
This way, authors could fix them in their source files.
So, the goggle source code displayed on the brave search about page would equal the hosted code.
Here are some of the issues which don't result in warnings:
Invalid Value
Options
https://github.com/Killthenews/brave/blob/de522bcc456646547f815a3de9ad4fcfa3494f35/news#L11-L18
Metadata
Illegal Range Value
Same for out of scope values for the action options:
https://github.com/9ktz/googles-technical/blob/cb75f9a9e4a9ce2f1d0a3304dbfddc57674fb96d/github.google#L8-L10
Multiple
$
'sSame for having multiple
$
inside the options part of the instructions.https://github.com/clening/DataProtectionGoggle/blob/19a3f9fd4bc9543c8f45ebfe4d0780826dc0ac18/dataprotection.goggle#L85
The text was updated successfully, but these errors were encountered: