From 3d6af189f2646c374ed12c77874e9a237c9004ca Mon Sep 17 00:00:00 2001
From: Braxton Salyer <braxtonsalyer@gmail.com>
Date: Sat, 15 Jun 2024 22:19:04 -0500
Subject: [PATCH] attempts at fixing build on macos with clang 17 and 18

---
 include/hyperion/mpl/list.h | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/include/hyperion/mpl/list.h b/include/hyperion/mpl/list.h
index e10746f..4cacddb 100644
--- a/include/hyperion/mpl/list.h
+++ b/include/hyperion/mpl/list.h
@@ -1692,15 +1692,15 @@ namespace hyperion::mpl {
             return TType{};
         }
     #else
-        /// @brief Used to extend the lifetime of the given value in a `constexpr` context.
-        /// MSVC can be bad about assuming an object's lifetime has ended in `constexpr`
-        /// contexts when it really hasn't.
-        ///
-        /// This provides usage consistency w/ the hack used for MSVC.
-        template<typename TType>
-        constexpr auto extend_constexpr_lifetime(const TType& value) -> decltype(auto) {
-            return value;
-        }
+        ///// @brief Used to extend the lifetime of the given value in a `constexpr` context.
+        ///// MSVC can be bad about assuming an object's lifetime has ended in `constexpr`
+        ///// contexts when it really hasn't.
+        /////
+        ///// This provides usage consistency w/ the hack used for MSVC.
+        //template<typename TType>
+        //constexpr auto extend_constexpr_lifetime(TType&& value) -> decltype(auto) {
+        //    return std::forward<TType>(value);
+        //}
     #endif // HYPERION_PLATFORM_COMPILER_IS_MSVC
 
         /// @brief Statically stack-allocated vector containing elements of type `TType`,
@@ -1865,7 +1865,12 @@ namespace hyperion::mpl {
             constexpr auto indices = [](auto range_obj, MetaValue auto size) {
                 constexpr auto to_process = detail::iota(0_value, size);
                 return detail::to_vector<usize, sizeof...(TTypes)>(range_obj(to_process));
-            }(detail::extend_constexpr_lifetime(range_object), list.size());
+            }
+#if HYPERION_PLATFORM_COMPILER_IS_MSVC
+            (detail::extend_constexpr_lifetime(range_object), list.size());
+#else
+            (range_object, list.size());
+#endif // HYPERION_PLATFORM_COMPILER_IS_MSVC
 
             // use those indices to sift the `list`
             return [indices]<auto... TIndices>(std::index_sequence<TIndices...>, auto _list) {