Add (simple) eslint config and fix some issues found using it.

Author: brcolow

.gitignore

@@ -0,0 +1,26 @@
+# Logs
+logs
+*.log
+npm-debug.log*
+yarn-debug.log*
+yarn-error.log*
+pnpm-debug.log*
+lerna-debug.log*
+
+node_modules
+dist
+dist-ssr
+*.local
+
+# Editor directories and files
+.vscode/*
+!.vscode/extensions.json
+.idea
+.DS_Store
+*.suo
+*.ntvs*
+*.njsproj
+*.sln
+*.sw?
+/competitors
+/papers

eslint.config.mjs

@@ -0,0 +1,11 @@
+import globals from "globals";
+import pluginJs from "@eslint/js";
+
+/** @type {import('eslint').Linter.Config[]} */
+export default [
+  {
+    files: ["**/*.js", "**/*.jsx", "**/*.mjs", "**/*.cjs"], 
+    ...pluginJs.configs.recommended,
+    languageOptions: { globals: globals.browser }
+  }
+];

main.js

@@ -403,12 +403,14 @@ function initialize3DTableGraphic(moodyReport) {
         canvas.height = height
         sizeChanged = true
       }
-      const fieldOfView = (45 * Math.PI) / 180 // radians
-      const aspect = canvas.width / canvas.height
-      const zNear = 0.1
-      const zFar = 1000.0
 
-      projectionMatrix.perspective(fieldOfView, aspect, zNear, zFar)
+      if (sizeChanged) {
+        const fieldOfView = (45 * Math.PI) / 180 // radians
+        const aspect = canvas.width / canvas.height
+        const zNear = 0.1
+        const zFar = 1000.0
+        projectionMatrix.perspective(fieldOfView, aspect, zNear, zFar)
+      }
     }
   })
 
@@ -552,7 +554,7 @@ function initialize3DTableGraphic(moodyReport) {
   const buffers = createAndBindTableVAO(moodyReport, gl, programInfo)
 
   function render(now) {
-    now = updateFps(now)
+    updateFps(now)
 
     drawTableSurface(moodyReport, gl, programInfo, buffers, texture)
     requestAnimationFrame(render)
@@ -572,7 +574,6 @@ function initialize3DTableGraphic(moodyReport) {
     frameCursor %= maxFrames
     const averageFPS = totalFPS / numFrames
     avgElem.textContent = averageFPS.toFixed(1)
-    return now
   }
 
   let   then = 0
@@ -839,7 +840,7 @@ function getNonColorBuffers(gl, moodyReport, zMultiplier) {
   gl.bufferData(gl.ARRAY_BUFFER, positions, gl.STATIC_DRAW)
 
   // Calculate and create normal buffer.
-  const lineNormals = moodyReport.vertices(zMultiplier).map(v => [0.0, 0.0, 0.0]).flat(1)
+  const lineNormals = moodyReport.vertices(zMultiplier).map(() => [0.0, 0.0, 0.0]).flat(1)
   // Each triangle has 3 vertices with the same surface normal.
   const triangleNormals = triangulation.map(triangle => {
     const length = Math.sqrt(triangle.surfaceNormal().x * triangle.surfaceNormal().x +
@@ -856,7 +857,7 @@ function getNonColorBuffers(gl, moodyReport, zMultiplier) {
   gl.bufferData(gl.ARRAY_BUFFER, normals, gl.STATIC_DRAW)
 
   // Calculate and create texture buffer.
-  const lineTextureCoords = moodyReport.vertices(zMultiplier).map(v => [0.0, 1.0]).flat(1)
+  const lineTextureCoords = moodyReport.vertices(zMultiplier).map(() => [0.0, 1.0]).flat(1)
 
   if (!(zMultiplier in boundingBoxCache)) {
     boundingBoxCache[zMultiplier] = getBoundingBox(moodyReport)
@@ -882,8 +883,8 @@ function getNonColorBuffers(gl, moodyReport, zMultiplier) {
   gl.bufferData(gl.ARRAY_BUFFER, textureCoordinates, gl.STATIC_DRAW)
 
   const types = new Float32Array(
-    moodyReport.vertices(zMultiplier).map(v => [0.0]).flat(1) // "Union jack" colored lines have type "0.0"
-    .concat(triangulation.map(_ => [1.0, 1.0, 1.0]).flat(1))  // Table vertices have type "1.0"
+    moodyReport.vertices(zMultiplier).map(() => [0.0]).flat(1) // "Union jack" colored lines have type "0.0"
+    .concat(triangulation.map(() => [1.0, 1.0, 1.0]).flat(1))  // Table vertices have type "1.0"
     .concat(0.0, 0.0, 0.0, 0.0, 0.0, 0.0))                    // Axis vertices have type "0.0"
 
   const typeBuffer = gl.createBuffer()
@@ -900,7 +901,7 @@ function getColorBuffer(gl, moodyReport, triangleVertices) {
   const minZ = Math.min(...triangleZValues)
   const maxZ = Math.max(...triangleZValues)
   // In case all values are the same minZ = maxZ (i.e. it is a totally flat plate with zero deviation) so we must avoid division by zero - just set all values to 0.0.
-  const normalizedTriangleZValues = minZ === maxZ ? triangleZValues.map(value => 0.0) : triangleZValues.map(value => (value - minZ) / (maxZ - minZ))
+  const normalizedTriangleZValues = minZ === maxZ ? triangleZValues.map(() => 0.0) : triangleZValues.map(value => (value - minZ) / (maxZ - minZ))
   const colorMappedZValues = normalizedTriangleZValues.map(value => interpolate(turboColormapData, value))
   console.log(colorMappedZValues)
   const colors = new Array(moodyReport.topStartingDiagonalTable.numStations).fill([0.9568627450980393, 0.2627450980392157, 0.21176470588235294, 1.0]).flat(1)

math.js

@@ -137,15 +137,15 @@ class Vector3 extends Float32Array {
     return Vector3.norm(this, this)
   }
 
-  static scale(out, a) {
+  static scale(out, a, scale) {
     out[0] = a[0] * scale
     out[1] = a[1] * scale
     out[2] = a[2] * scale
     return out
   }
 
-  scale(a) {
-    return Vector3.scale(this, a)
+  scale(a, scale) {
+    return Vector3.scale(this, a, scale)
   }
 
   static magnitude(a) {

moody.js

@@ -1,5 +1,3 @@
-import { Vector3 } from "./math.js"
-
 const sineOfOneArcsecond = 0.00000484813
 
 function roundTo(n, numDecimalPlaces = 2) {

package.json

@@ -4,9 +4,15 @@
 	"description": "",
 	"main": "moody.js",
 	"scripts": {
-		"serve": "npx http-server -c-1 -p 5000 -o"
+		"serve": "npx http-server -c-1 -p 5000 -o",
+		"lint": "npx eslint ."
 	},
 	"keywords": [],
 	"author": "Michael Ennen (brcolow)",
-	"license": "MIT"
-}
+	"license": "MIT",
+	"devDependencies": {
+		"@eslint/js": "^9.17.0",
+		"eslint": "^9.17.0",
+		"globals": "^15.14.0"
+	}
+}

webgl-debug.js

@@ -1,3 +1,4 @@
+/* eslint-disable */
 /*
 ** Copyright (c) 2012 The Khronos Group Inc.
 **