Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strange design when wallet widget is minimized #29

Open
herrhelms opened this issue Oct 27, 2016 · 11 comments
Open

strange design when wallet widget is minimized #29

herrhelms opened this issue Oct 27, 2016 · 11 comments

Comments

@herrhelms
Copy link

Is this the intended behavior/design for the widget? See screenshot below:

minimized

Running on iPhone7/10.1 breadwallet v0.6.4-46

@voisine
Copy link
Member

voisine commented Oct 27, 2016

That's strange, I also have an iPhone7/10.1 and mine looks like this:

img_0115

Does tapping Show More/Show Less, or removing and re-adding the widget make any difference?

@herrhelms
Copy link
Author

I tried but still the same thing

@voisine
Copy link
Member

voisine commented Oct 27, 2016

Ah, I bet it's because it's using the QR image cached from the previous version of the widget. When you receive funds it will generate a new one for the new address that I think is a little larger.

@herrhelms
Copy link
Author

Interesting train of thought. Okay, that would make sense in my case. So just a matter until someone wires some satoshis 😂 LOL

@voisine
Copy link
Member

voisine commented Oct 27, 2016

In the interest of science...

@herrhelms
Copy link
Author

Yeah to science! Thanks for that! Here's what happened: QR code/address within app changed. I swiped to see the Widget, the old QR was shown for a second then replaced with the new one. - Same 'broken' layout though, and I did remove the widget, and pressed show less/more a couple of times. Should I reimburse you?

@voisine
Copy link
Member

voisine commented Oct 27, 2016

Darn... so strange that I can't reproduce it on the same device and OS version.

No you can keep the buck... don't spend it all in one place.

@herrhelms
Copy link
Author

I just took a quick look into the repo - Some weird constrains behaving mysteriously upon messing with self.preferredContentSize - I will try to tinker with it a little over the weekend. The minified widget has some room for improvement, right?

@voisine
Copy link
Member

voisine commented Oct 28, 2016

yes, I quickly reworked it to get something that didn't look like ass with the new iOS 10 widgets, and maybe didn't succeed.

@voisine
Copy link
Member

voisine commented Oct 28, 2016

If you're feeling ambitious and want to re-do it in swift 3, then it would likely make it into the swift 3 app rewrite we're doing.

@BeauNouvelle
Copy link

@voisine Where can we help contribute to the Swift version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants