Skip to content

[WIP] Allow custom panic messages in assert_* macros #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Allow custom panic messages in assert_* macros #45

wants to merge 1 commit into from

Conversation

adrianwong
Copy link
Contributor

@adrianwong adrianwong commented Nov 26, 2018 •
edited
Loading

This is an attempt to resolve #44.

@adrianwong adrianwong changed the title [WIP] Accept custom panic messages in assert_* macros [WIP] Allow custom panic messages in assert_* macros Nov 26, 2018
@joshburkart
Copy link

Would love to get this in, was just looking for this feature! Anything we're waiting on? @brendanzab?

@jonaspleyer
Copy link

Hey there, In case you are still interested in working on this feature, I have forked the approx crate under https://crates.io/crates/approxim. I have already included many of the other PRs such as #57, #67, #69, #83, #87, #90, #91, #92. Unfortunately I was not able to easily merge your PR as it has been some time and the macros have changed since then. You are more than welcome to open a new PR over there.
https://github.com/jonaspleyer/approxim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding messages to assert_* macros
3 participants
@adrianwong @joshburkart @jonaspleyer