Skip to content

fix #82 #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix #82 #83

wants to merge 3 commits into from

Conversation

MqCreaple
Copy link

@MqCreaple MqCreaple commented Jul 23, 2023

Add support for NotNan and OrderedFloat in crate ordered-float.

fix #82

@MqCreaple
Copy link
Author

Any updates from maintainers? @sebcrozet @brendanzab

@jonaspleyer
Copy link

Hey there. I have forked the approx crate under https://crates.io/crates/approxim. I have already included many PRs of the original approx crate such as #57, #67, #69, #83, #87, #90, #91, #92. As you can see, your PR was included as well. This new crate approxim should work as a drop-in-replacement for approx. Feel free to try it out and let me know what you think.

@MqCreaple
Copy link
Author

Sure. So is the approx crate obsolete?

@jonaspleyer
Copy link

Sure. So is the approx crate obsolete?

The authors seem to not have responded to any PRs or issues since roughly end of 2021. Unfortunately this is how far my knowledge goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

impl RelativeEq for NotNan and OrderedFloat from ordered_float
2 participants