Fix for issue 126 - currencySymbol to Uppercase #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Real Flipclock animation supportin 12h/24h modes
Real Flipclock animation supportin 12h/24h modes
Real Flipclock animation supportin 12h/24h modes
Real Flipclock animation supporting 12h/24h modes
2 serial.println were in the code that shouldn't be there.
In case twelvedata sends the currency like for the Stock BARC as GBp instead of GBP the currency will not display. Before comparing the currency will be converted to uppercase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the StockdataModel.cpp the setcurrency function compares against uppercase currencies. If twelvedata sends someting in lowercase, the currency symbol is missing.