Stock Api & styling updates #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Main -> Dev
With this method the widgets can be identified and during startup we can now display which widget is loading (and potentially see which one is taking a long time or crashing or...)
Spelling (didget -> digit), also Widgets now have a getName() method
Cleanup of comment capitalization and typos
Pushing this to both dev and main(not norm to push right to main, but need to do this as a one-off as the previous stock API has stopped working). API now supports global markets, crypto, and forex. See default examples for how to use these. A small thing to be fixed: the current default font does not support the euro or pound symbol for when showing non-NA stocks, so i just use "EUR/GBP" as a placeholder. Once we adress fonts this will be an easy thing to swap out. Also removed some unused wokwi/display driver code in main now that we're all on the same hardware Code is poorly commented & formated,. sorry lol
ericthelin
reviewed
Oct 29, 2024
| float m_currentPrice = 0.0; | ||
| float m_volume = 0.0; | ||
| float m_HP = 0.0; | ||
| float m_LP = 0.0; |
There was a problem hiding this comment.
maybe m_highPrice and m_lowPrice?
|
|
||
|
|
||
|
|
||
| display.fillRect(0,70, screenWidth, 49, TFT_WHITE); // rgb565 colors |
There was a problem hiding this comment.
extra whitespace should be removed and the formatting on the comment is off
Fixing bad formatting & varible naming. Moved currency symbol logic to the datamodel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing this to both dev and main(not norm to push right to main, but need to do this as a one-off as the previous stock API has stopped working). The main push also has some small changes brought over from dev as well such as some comment capitalization fixes.
API now supports global markets, crypto, and forex. See default examples for how to use these.
A small thing to be fixed: the current default font does not support the euro or pound symbol for when showing non-NA stocks, so i just use "EUR/GBP" as a placeholder. Once we address fonts this will be an easy thing to swap out.
Also removed some unused wokwi/display driver code in main now that we're all on the same hardware
Code is poorly commented & formatted,. sorry lol