Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cartopy requirement optional for installs. #2

Open
brews opened this issue Jan 29, 2018 · 2 comments
Open

Make cartopy requirement optional for installs. #2

brews opened this issue Jan 29, 2018 · 2 comments

Comments

@brews
Copy link
Owner

brews commented Jan 29, 2018

Right now, baysparpy depends on cartopy. Cartopy is needed to plot the gridpoints (analogmap()) output from an analog prediction (predict_seatemp_analog()). Other components in the package do not need cartopy, just this one plotting function.

Cartopy can be a pain to install, especially for new users.

Might want to make cartopy optional for installs, note this in the documentation and print out an error message on import saying that cartopy needs to be installed... something like this.

@brews brews added this to the v0.0.2 milestone Jan 29, 2018
@brews
Copy link
Owner Author

brews commented Feb 1, 2018

Be sure to declare it as an extra requires in setup.py (https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-dependencies)

@brews brews removed this from the v0.0.2 milestone Feb 8, 2018
@brews
Copy link
Owner Author

brews commented Feb 8, 2018

I'm removing this from the v0.0.2 milestone because I'm uncertain about this. The package is so large that we are most likely going to distribute this through conda anyways. Wait until we get more user feedback and see if the required cartopy dependency is really a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant