Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layers/depth seem non-optimal #2

Open
henkjan-sneller opened this issue Feb 22, 2023 · 4 comments
Open

Layers/depth seem non-optimal #2

henkjan-sneller opened this issue Feb 22, 2023 · 4 comments

Comments

@henkjan-sneller
Copy link

While plotting a machine generated network I noticed that the order of nodes matters (for the layer assignment) while it should not AFAICT.

For example 2:5,0:1,4:5,0:3 yields:
exampleNet

While 2:5,4:5,0:1,0:3 yields:
exampleNet
and I expected it to be the same as the previous one since the layers and dephts did not change.

Q: is this a bug or a feature?

@brianpursley
Copy link
Owner

Yes, this is a bug.

It needs some code to "collapse" the network so that there are no unnecessary gaps at any given depth.

@brianpursley
Copy link
Owner

@henkjan-sneller Thanks for reporting this. It should be fixed by a change I just made.

@HJLebbink
Copy link

Thanx!

@brianpursley
Copy link
Owner

The optimal depth grouping has been fixed, but it seems within a single depth, the comparators are still not organized as well as they could be.

Screenshot_20240506-184655

So maybe there is still some work that can be done to improve this.

@brianpursley brianpursley reopened this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants