Releases: brigadecore/brigade
Releases · brigadecore/brigade
brigade v1.2.0-beta.2
brigade v1.2.0-beta.1
- corresponding node dependency updates for worker 8aff48d (Kent Rancourt)
- worker changes for build-level cloneURL c8432df (Kent Rancourt)
- controller changes for build-level cloneURL 6fbbed9 (Kent Rancourt)
- project_create.go: help message word correction a600ced (ethan)
- more thorough custom worker documentation (#968) 05d4f29 (Kent Rancourt)
- Add experimental volumes and volumeMounts properties to jobs (#966) 8525067 (Radu M)
- chore(*): update license to Apache 2.0 per CNCF (#962) 6f2bf49 (Vaughn Dice)
- feat(brig): option to show logs from vcs-sidecar (#967) a1b7694 (KUOKA Yusuke)
- Initial test with the GitHub library from brigade-utils (#963) a0c1247 (Radu M)
- brig project create: allow undefined storage classes a5db00b (Kent Rancourt)
- brig project create: add support for specifying shared secret or leaving undefined 48188e6 (Kent Rancourt)
- Update worker packages to address vulnerabilities (#959) 8549dae (Radu M)
- Fix image pull secrets not being set in NewProjectFromSecret (#953) 1caf066 (Radu M)
- e2e first commit (#950) b02c99b (Dimitris-Ilias Gkanatsios)
- Add resolution for NPM package lodash due to security vulnerabil… (#951) 523ab2f (Radu M)
- feat(brig): achieve flag parity for rerun command (to run); add unit tests 1115140 (Vaughn Dice)
- fix(main.go): remove double print of error message e3a2763 (Vaughn Dice)
- fix(brig): silence usage on errors by default for root comand e0c13f0 (Vaughn Dice)
- docs(scripting.md): add project-level config needed for docker setups 6022944 (Vaughn Dice)
- added instructions to develop with kind (#937) 1b46b15 (Dimitris-Ilias Gkanatsios)
- add some more dev docs 90a611b (Kent Rancourt)
- more improvements to be more win-friendly ae878de (Kent Rancourt)
- don't rely on host-os-specific command when orchestrating containers d9117f9 (Kent Rancourt)
brigade v1.1.0
- fix(brig): remove setting p.Repo fields for non-VCS project 697a29a (Vaughn Dice)
- fix(brigade-worker): ensure backwards compatibility for project name and repo name values 8d8af75 (Vaughn Dice)
- docs(design.md): Post-1.0.0 design updates bb64ca3 (Vaughn Dice)
- docs(*): v1.1.0 release updates d9a89a4 (Vaughn Dice)
- make sure version is set correctly for brig binaries 5effee0 (Kent Rancourt)
- brig project create templates (#892) e372f1f (Dimitris-Ilias Gkanatsios)
- feat(brigade.js): add handlers for issue_comment and check_run:rerequested events 5edee06 (Vaughn Dice)
- emphasizing that job timeout is in milliseconds (#925) 5559a34 (Dimitris-Ilias Gkanatsios)
- Addressing PR comments. 829252e (Jakub Borys)
- minor brigade.js cleanup 94690a0 (Kent Rancourt)
- use newer go image 456c74a (Kent Rancourt)
- make worker docker build properly depend on the TRACKED dependencies 9edc4da (Kent Rancourt)
- doc updates ae8ceda (Kent Rancourt)
- Dockerfile /tmp/ fixes 6db8b43 (Kent Rancourt)
- fix error in brigade.js c48286f (Kent Rancourt)
- filter docker context for each image build 444d576 (Kent Rancourt)
- improve the build and release processes 03064ab (Kent Rancourt)
- track vendored code c10f9e1 (Kent Rancourt)
- make runSuite() fail build when any job fails 9913621 (Kent Rancourt)
- fix: wrong
helm upgrade
usage in "Installing Brigade" a9ecb0f (KUOKA Yusuke) - fix(brigade-worker): uppercase BRIGADE_LOG_LEVEL val for deriving correct enum val 2836709 (Vaughn Dice)
- allow default worker command to also be set via env var (#910) af8b347 (Kent Rancourt)
- Change to use brig create project command f701e6d (Jakub Borys)
- Improve sentence 57853bc (Jakub Borys)
- Remove k8s context from commands 097a860 (Jakub Borys)
- Mention Ingress eb67c4c (Jakub Borys)
- Link to GitHub integration 228f869 (Jakub Borys)
- allow global configuration of default storage classes (#908) 502eb90 (Kent Rancourt)
- [#864] add cookie disclaimer a771162 (flynnduism)
- [#864] add google analytics w/ anonymized user ips d96fed6 (flynnduism)
- [docs] add anchor links for deep linking to section titles (#894) 82cd846 (Ronan Flynn-Curran)
- [#840] add alias redirects to doc front matter 758c25c (flynnduism)
- [#840] add alias redirects to doc front matter 32f9cb7 (flynnduism)
- [#909] change hugo theme for relative urls 47d4d86 (flynnduism)
- [#909] change hugo config for relative urls 98cf9d9 (flynnduism)
- [#909] change hugo config for relative urls afd1238 (flynnduism)
- [#909] edit docs config 179abc2 (flynnduism)
- [#909] change hugo config for relative urls c9d9314 (flynnduism)
- make worker command configurable globally with a controller flag (#906) 3879c9d (Kent Rancourt)
- Fix image location 864ccc4 (Jakub Borys)
- Preview Environments Tutorial 0a8fa2e (Jakub Borys)
- fix sorting on topics docs cd3f902 (Dimitris-Ilias Gkanatsios)
- fix(k8s.ts): only log/reject the error message 9ca9b33 (Vaughn Dice)
- Use
module-alias
to improve module resolution in Brigade scripts 445a6b1 (Chris Chambers) - Eliminates a yarn race condition when installing brigade.json deps b7b83a8 (Chris Chambers)
- fix config.toml to include quickstart link (#893) 14d3496 (Dimitris-Ilias Gkanatsios)
- brig check initial implementation (#881) 8445f8a (Dimitris-Ilias Gkanatsios)
- correct storage link (#889) cd88a8c (Dimitris-Ilias Gkanatsios)
- fix code links on scripting-scripting advanced (#885) ed1382b (Dimitris-Ilias Gkanatsios)
- Added Generic Gateway quickstart (#851) 1b849be (Dimitris-Ilias Gkanatsios)
- docs(ingress.md): fix manifest indent ee54455 (Vaughn Dice)
- Add CNCF Community Code of Conduct (#875) d71270e (Radu M)
- copy contributing info into docs/content and add nav link 22f3713 (flynnduism)
- Add license scan report and status d7c6337 (fossabot)
- Add CII badge 6ba44fd (Radu Matei)
- Missing [ in image link 6d16368 (Jérôme Petazzoni)
- create manual doc sites menu in config.toml dd16982 (flynnduism)
- create manual doc sites menu in config.toml 01eceb5 (flynnduism)
- docs fix image paths 4beccc1 (flynnduism)
- chore(brigade-worker): bump version to v1.0.0 a78f119 (Vaughn Dice)
brigade v1.0.0
- docs(*): bump version in docs to latest v1.0.0 release 6f17903 (Vaughn Dice)
- docs(CONTRIBUTING.md): add contributing doc; link from README 3d769e8 (Vaughn Dice)
- chore(LICENSE): update license 99da458 (Vaughn Dice)
- chore(*): update image org to brigadecore b62425a (Vaughn Dice)
- ref(brigade.js): remove acr publishing 29a93fe (Vaughn Dice)
- Revert change in Gopkg.lock that reference inexistent package 3d00112 (Radu Matei)
- Update yarn.lock with new @brigadecore/brigadier package 8179cc6 (Radu Matei)
- chore(*): further brigadecore docs updates b49955d (Vaughn Dice)
- chore(*): further brigadecore updates, mostly npm library references 6281ca1 (Vaughn Dice)
- chore(*): updates per org change to brigadecore a638d71 (Vaughn Dice)
- repoint urls from azure/brigade to brigadecore/brigade b5c80de (flynnduism)
- remove netlify.toml b137b9e (flynnduism)
- add types of GW events 4ae0cdc (Dimitris-Ilias Gkanatsios)
- Update package.json version for Brigade worker 5286dc9 (Radu Matei)
- removing custom navigation from docs (#827) 394a298 (Dimitris-Ilias Gkanatsios)
- update netlify config 219ce7e (flynnduism)
- move netlify config to root 4ca38c4 (flynnduism)
- [docs] simplify projects.md title for clearer menu 81d2c81 (flynnduism)
- [docs] fix internal doc links on index pages fd64761 (flynnduism)
- update docs links 14551a0 (flynnduism)
- add the docs/resources dir to git to debug the netlify build errors 018c8c2 (flynnduism)
- use hugo pipes for assets cd422ef (flynnduism)
- docs: add lukepatrick as a code owner 6140dc7 (Matt Butcher)
- Add CODEOWNERS file as a record of core maintainers (#826) a7aea26 (Matt Butcher)
- mobile layout adjustments 73a3c26 (flynnduism)
- docs(releasing.md): update brigade-charts section dfb6f93 (Vaughn Dice)
- make the left side menu sticky on scroll d229b2c (flynnduism)
- fix path to logo 67040bb (flynnduism)
- add favicon 6f255ec (flynnduism)
- remove hugo output from version control 0224969 (flynnduism)
- fix up image paths b97459a (flynnduism)
- move sass dir 3dd69e1 (flynnduism)
- remove unused hugo themes a2f7e7e (flynnduism)
- theme styling and content indexing 08a62e2 (flynnduism)
- add techdoc-brigade theme 7a6536c (flynnduism)
- update gitignore cb16bbd (flynnduism)
- netlify toml 45c8a3d (flynnduism)
- Utilize the techdoc theme for hugo ac28d96 (flynnduism)
- update gitignore 8a47923 (flynnduism)
- chore(*): update node dependencies db7aba6 (Adam Reese)
- Update npm packages 1b2fa55 (Radu Matei)
- Update mocha to ^v4.0.1 to update debug and growl packages e9f1aee (Radu Matei)
brigade v1.0.0-beta.2
- Update brigadier to v0.4 7c35c90 (Radu Matei)
- Temporarily comment the ASCII Cinema URL as it is archived 248c580 (Radu Matei)
- incorporating PR feedback 65ff258 (Dimitris-Ilias Gkanatsios)
- Add document for gateways behind ingress with TLS 1169d13 (Radu Matei)
- CloudEvents 0.2 support af4eec9 (Dimitris-Ilias Gkanatsios)
- remove GitHub related code from Generic Gateway ecd099d (Dimitris-Ilias Gkanatsios)
- StartTime instead of EndTime on
brig build list
4951371 (Dimitris-Ilias Gkanatsios)
brigade v1.0.0-beta.1
- fix regex matching on the service account 1630936 (Ryan Belgrave)
- allow setting the service accout on projects with regex validation e407ba7 (Ryan Belgrave)
- ref(github-gw): resolve TODOs in Makefile 30d2b44 (Vaughn Dice)
- ref(github-gw): update documentation c362e7a (Vaughn Dice)
- Add documentation for importing local dependencies in brigade.js ef8e51f (Radu Matei)
- ref(github-gw): remove github-gateway in favor of brigade-github-app (as opt-in chart dependency) 463eb7c (Vaughn Dice)
- docs(*): update project docs to use brig as default 0b95285 (Vaughn Dice)
- docs(releasing.md): note Brigade Project chart as well 8f78d4e (Vaughn Dice)
- docs(topics): add testing doc c0dece7 (Vaughn Dice)
- Add tests for require.ts 2e11884 (Radu Matei)
- Enable pretty import paths for local imports (from repo) in brigade.js bc27385 (Radu Matei)
brigade v0.20.0
- docs(*): add releasing.md doc, bump strings in anticipation of v0.20.0 6b915d2 (Vaughn Dice)
- docs fix 51c8695 (Dimitris-Ilias Gkanatsios)
- docs(topics/secrets): add remote store and K8s secret examples 1707137 (Vaughn Dice)
-
- moved GenericGateway to a separate package - altered brig project create so that genericGateway secret is generated on advanced options 457a4d0 (Dimitris-Ilias Gkanatsios)
- Add documentation for generic gateway b3a1e8b (Dimitris-Ilias Gkanatsios)
- Add tests for generic webhook 5d832c1 (Dimitris-Ilias Gkanatsios)
- Initial generic webhook ae3b115 (Dimitris-Ilias Gkanatsios)
- feat(Makefile,developers.md): add development-centric Makefile targets; add to docs e8ff421 (Vaughn Dice)
- docs(topics): remove older install.md, relocated nfs instructions into storage.md 4d99730 (Vaughn Dice)
- docs(topics): add navigation links 67542a8 (Vaughn Dice)
- fix LastBuild in ProjectBuildSummary c82c6cc (Dimitris-Ilias Gkanatsios)
- fix(deps): add version constraints to Gopkg.toml (#779) fbebdb5 (Adam Reese)
- quickstart 03f0749 (Dimitris-Ilias Gkanatsios)
- initial implementation 068c0fb (Dimitris-Ilias Gkanatsios)
- custom brigade.js path aa1c84c (Dimitris-Ilias Gkanatsios)
- add log message when secretKeyRef is not allowed c29e50e (Ryan Belgrave)
- add the ability to toggle usage of secretKeyRef in jobs 0488e5d (Ryan Belgrave)
- Actually use the job shell when defining the container cmd 1b8594e (Radu Matei)
- Update TypeScript to 3.2.2 and add build target in CI dfca5b7 (Radu Matei)
- Add link to Azure DevOps / VSTS gateway 0c51c4f (Radu Matei)
- WIP ref(worker): switch to @azure/brigadier (#585) b7f799b (Matt Butcher)
- Update bacongobbler/browser to v1.1.0 dfbabf8 (Radu Matei)
- docs refactor 1818f0f (Dimitris-Ilias Gkanatsios)
- Add default namespace for brig through the BRIGADE_NAMESPACE environment variable 443626b (Radu Matei)
- revert unnecessary blanks 4810fc1 (Dimitris-Ilias Gkanatsios)
- changes as per PR review 41b7055 (Dimitris-Ilias Gkanatsios)
- Add GitHub issue and PR templates fabf4af (Radu Matei)
- minor fix on chart link (#733) 491d033 (Dimitris-Ilias Gkanatsios)
- replaced video links (#734) 9dbf63a (Dimitris-Ilias Gkanatsios)
- fix linter errors (#737) 243afac (Dimitris-Ilias Gkanatsios)
- Revert "fix lint errors" b676ec1 (Dimitris-Ilias Gkanatsios)
- fix lint errors 7f89075 (Dimitris-Ilias Gkanatsios)
- change displayLogs to streamLogs e59b44c (Dimitris-Ilias Gkanatsios)
- Add a support & feedback section to the readme 9a26705 (Ryan Belgrave)
- ref(brigade.js): remove helm test 91fae77 (Vaughn Dice)
- ref(Makefile): remove index-chart target 124c66b (Vaughn Dice)
- update docs/index.yaml with new chart urls b1b422b (Vaughn Dice)
- ref(*): remove charts 266add4 (Vaughn Dice)
- allow configuring the service account 7cdd8b5 (Ryan Belgrave)
- don't display "Running" if displayLogs==true 0f2f87d (Dimitris-Ilias Gkanatsios)
- brig run now "follows" job pod logs 2957bf7 (Dimitris-Ilias Gkanatsios)
- show job logs (#643) e8aad8a (Dimitris-Ilias Gkanatsios)
- Remove confusing green checkmark from getting started doc 6cc93d1 (Radu Matei)
- fix(brigade.js): add some fixes around publish/release - pass/consume correct params for goDockerBuild - return job from release func, to be ran with run() as appropriate - add noop() function 55b2e45 (Vaughn Dice)
- ref(Makefile): switch to golangci for linting 1ff999a (Vaughn Dice)
- added retry logic to sidecar (#723) 27656fe (Dimitris-Ilias Gkanatsios)
- fixed brig project create --replace (#720) 05cfb26 (Dimitris-Ilias Gkanatsios)
- ref(brigade.js): Notification conclusion adjustment 766633b (Vaughn Dice)
- fix(brigade-controller,worker): do not add sidecar containers/volumes/volumeMounts to worker or job pods if disabled f871cb0 (Vaughn Dice)
- ref(brigade.js): semicolon consistency 5d6170c (Vaughn Dice)
- Revert "Merge branch 'generic-webhook' of https://github.com/dgkanatsios/brigade" c9e6ae7 (Dimitris-Ilias Gkanatsios)
- ref(brigade.js): discard stdout on prereq apk install bf3b49a (Vaughn Dice)
- feat(project_create.go): allow for disabling vcs sidecar via brig create c5fd773 (Vaughn Dice)
- ref(brigade.js): use GitHub App/Checks API 548d427 (Vaughn Dice)
- fix(charts/brigade-project): allow vcs-sidecar NONE 83664b6 (Vaughn Dice)
- ref(charts): enable RBAC by default 857a0fe (Vaughn Dice)
- Update invalid job name error message. 6f47f4a (Josué Padilla)
- chore(chart): update brigade 0.19.0 chart tgz/index.yaml 6aeacc8 (Vaughn Dice)
- PoC for #602 afb4c34 (Dimitris-Ilias Gkanatsios)
- fix(chart): update github api link in values.yaml 4e4bb7e (Vaughn Dice)
Brigade v0.19.0
Changelog
- Brigade release v0.19.0 bd26da8 (Vaughn Dice)
- fix(charts/brigade): add legacy label in for upgrades 49fe844 (Vaughn Dice)
- Add level in workerResources values 243d7f4 (Julio Chana)
- Use Chart.AppVersion insted of Chart.Version for image tag e0a6b42 (Julio Chana)
- Values in args cannot be quoted c419350 (Julio Chana)
- Add worker resources in controller deployment in chart 621e869 (Julio Chana)
- Wrap vcsSidecarResources in chart so it satifies linter fa9c189 (Julio Chana)
- Use correct secret management for init-container resources 94d3747 (Julio Chana)
- Leave resources undefined if not values given 76c68bc (Julio Chana)
- Set the vcs init-container resources by the worker 663128c (Julio Chana)
- Update project chart to have the sidecar resources e72f1ea (Julio Chana)
- Add resources for controller init-container bb18782 (Julio Chana)
- Add resources for controller main container 27ed5dc (Julio Chana)
- added "-c", fixed a small bug in build-list, thanks @vdice! 4ee529a (Dimitris-Ilias Gkanatsios)
- minor addition to dev documentation cb8247a (Dimitris-Ilias Gkanatsios)
- added a sort method 4e7735e (Dimitris-Ilias Gkanatsios)
- refactored test methods fbfb52d (Dimitris-Ilias Gkanatsios)
- added test for
brig build list
c8046a0 (Dimitris-Ilias Gkanatsios) - fix for #601 and #612 9e117b8 (Dimitris-Ilias Gkanatsios)
- fix for #698 02560e8 (Dimitris-Ilias Gkanatsios)
- better wording on skipping message 7e271fe (Dimitris-Ilias Gkanatsios)
- better usage strings for deletes 61e67c8 (Dimitris-Ilias Gkanatsios)
- change error logic for DeleteBuild method 9844e15 (Dimitris-Ilias Gkanatsios)
- updated pflag 397860f (Dimitris-Ilias Gkanatsios)
- minor error 0785ee3 (Dimitris-Ilias Gkanatsios)
- updated cobra and added cobra.ExactArgs fc05cab (Dimitris-Ilias Gkanatsios)
- added --force for delete and delete-all 807076a (Dimitris-Ilias Gkanatsios)
- revert documentation 7a02ede (Dimitris-Ilias Gkanatsios)
- minor e01833b (Dimitris-Ilias Gkanatsios)
- brig build delete and brig build delete-all implementation 0cee161 (Dimitris-Ilias Gkanatsios)
- Add resource job requests and limits docs e42b29c (Xabier Larrakoetxea)
- Add ability to set resource limits on jobs 3b9f034 (Xabier Larrakoetxea)
- ref(brigade.js): add dockerhub publish job, split up acrBuild 365758c (Vaughn Dice)
- ref(brigade-worker): don't supply a default ref 89447f2 (Vaughn Dice)
- feat(controller): export NewWorkerPod edb4e04 (Jeehwan)
- feat(chart/controller): add enabled option for controller (enabled by default) 025341e (Jeehwan)
- extracted the job name max length to class constant. d0ef1e2 (Gagandeep Singh)
- Update chart labels to follow the new convention (#678) 391a716 (Andreas Ölund)
- Added job name length check in job constructor 76dd5fa (Gagandeep Singh)
- Fix golint warning: redundant if ...; err != nil check, just return error instead. 4b1c5b9 (Joseph Herlant)
- docs(developers.md): add note on js bootstrap/test; add bootstrap-js make target 96ae362 (Vaughn Dice)
- feat(Makefile): add target to lint charts aa64fbf (Adam Reese)
- docs(storage.md): add Azure File example fb5881c (Vaughn Dice)
- add else code to fix issue 469, invalid kubernetes pod a238bab (Chaya Danzinger)
- docs(scripting_advanced.md): fix typos 4a9ef02 (Vaughn Dice)
- Reference asdf-brig in README. 7010ff1 (Ben Limmer)
- ref(Makefile/brigade.js): append .exe to Windows binary at build stage 6780ee9 (vdice)
- Fix brig run file flag be2f827 (Jakub Borys)
- fix(brigade.js): change e.event to correct e.type, use e.revision.ref instead of parsing payload f472de3 (vdice)
- bump golang img to 1.11 in brigade.js, also use make vendor everywhere for deps 2050d7d (vdice)
- fix(*): address linting errors, add test-style to brigade build task 10e8ea6 (vdice)
- fix(brigade.js): remove redundant/incorrect rootfs cp cmd destination 5750254 (vdice)
- fix(docs): update commit string references in docs e6a810a (Ishaan Malhi)
- fix(docs): add correct key for commit sha value de9b822 (Ishaan Malhi)
brigade v0.18.0
Changelog
- Brigade release v0.18.0 e139cfa (vdice)
- Fix invalid_format for Git SSH Keys. (#647) ed39ffb (Ben Limmer)
- fix(charts): fix incorrect logic for default sidecar 039c247 (Adam Reese)
- bump alpine to 3.8 dc37274 (Arnaud Meukam)
- docs(tutorial): misc fixes cfb9885 (vdice)
- fix(worker): handle transient faults (#625) (#626) d6f2a59 (Jeehwan Cho)
- fix(controller): allow read/write on sidecar volume d71dcb2 (Adam Reese)
- feat(brig): Exit with error code if build fails (#415) e7b8606 (JJ Fliegelman)
- fix(chart/project): do not override default in values.yaml 7371e31 (Adam Reese)
- feat(brig): alternative destination for script runner logs (#629) 71f8d6e (KUOKA Yusuke)
- Update developers.md (#631) 51b925e (Hadrien TOMA)
- fix(doc): broken code block in the topics/developers doc (#630) 7185772 (KUOKA Yusuke)
- feat(brig):
brig run
as a go library (#623) 5cab729 (KUOKA Yusuke) - properly initialize logger in BuildStorage to prevent crash when project does not exist (#619) e56d6cd (Mansoor Nasir Cheema)
- fix: add brig exec as alias for brig run (#616) 4d8c5fe (Matt Butcher)
- add missing comma 72255a3 (Matthew Fisher)
- fix(prestart): don't call .toString() on an error d2b125b (Matthew Fisher)
- Add brigade-exporter to related projects section on the readme d970092 (Xabier Larrakoetxea)
- fix(*): add project default script to worker 1a1f190 (Adam Reese)
- Add more info on kube-lego and cert-manager be20181 (Radu Matei)
- fix(docs): add git add . step before commit 1f540a5 (Michelle Noorali)
- fix(git-sidecar): remove hard reset in sidecar e7d76c0 (Adam Reese)
- vacuum skips deleting currently running builds if skipRunningBuilds is true (false by default). Previously, vacuum deletes all builds regardless of whether they are running. (#603) 3ebb2a7 (Jeehwan Cho)
- chore(*): run make format ebeebc6 (Adam Reese)
- fix(brig): generate shared secret when none exists (#600) 47fb717 (Matt Butcher)
- Remove unused variable 79eda36 (Radu Matei)
- Re-use globalNamespace flag for brig dashboard d0ae0cc (Radu Matei)
- use watch in worker for efficiency #592 2211f06 (Jeehwan)
- add --verbose flag bf0bad4 (Matthew Fisher)
brigade v0.17.0
This is a bugfix release (with a feature that we accidentally snuck in there).
Changelog
- Brigade release v0.17.0 8dad908 (Adam Reese)
- fix(brig): set a default sidecar (#591) c5907e7 (Matt Butcher)
- fix(chart): set max builds to -1 by default (#589) fb0c2a0 (Matt Butcher)
- feat(brig): add -f flag to rerun command (#588) 89b790e (Matt Butcher)
- fix(brigade, worker): fixing a few minor nits (#583) 8e1b869 (Matt Butcher)