Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-unitary foreground unit processes are not scaled #55

Closed
muelleram opened this issue Jun 12, 2024 · 2 comments
Closed

non-unitary foreground unit processes are not scaled #55

muelleram opened this issue Jun 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@muelleram
Copy link
Collaborator

see test test_nonunitary_unitprocess on this issue branch.

If a foreground process produces an amount other than 1, this is not used to scale the inputs of the timeline, leading to wrong scores. Should be relatively easy to adjust our code.
@muelleram muelleram added the bug Something isn't working label Jun 12, 2024
@muelleram
Copy link
Collaborator Author

aeeb0af

@TimoDiepers TimoDiepers linked a pull request Jun 14, 2024 that will close this issue
55 non unitary foreground unit processes are not scaled #57
Closed
@TimoDiepers
Copy link
Member

fixed with #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

55 non unitary foreground unit processes are not scaled brightway-lca/bw_timex
2 participants
@muelleram @TimoDiepers