From 93ae495cf0df78dc8cb26f8bceba05178cdc1524 Mon Sep 17 00:00:00 2001 From: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Date: Sun, 26 May 2024 16:10:14 -0700 Subject: [PATCH] Update Failing tests --- .../Tests/GetApiRateLimitsTests_NoCancellationToken.cs | 10 ++++++---- .../GetApiRateLimitsTests_WithCancellationToken.cs | 10 ++++++---- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/GitHubApiStatus.UnitTests/Tests/GetApiRateLimitsTests_NoCancellationToken.cs b/src/GitHubApiStatus.UnitTests/Tests/GetApiRateLimitsTests_NoCancellationToken.cs index 400b9e6..184bd7a 100644 --- a/src/GitHubApiStatus.UnitTests/Tests/GetApiRateLimitsTests_NoCancellationToken.cs +++ b/src/GitHubApiStatus.UnitTests/Tests/GetApiRateLimitsTests_NoCancellationToken.cs @@ -130,12 +130,14 @@ public async Task GetApiRateLimits_ValidSearchApiRequest() Assert.GreaterOrEqual(searchApiStatus_Final.RateLimitReset_DateTime, startTime); Assert.GreaterOrEqual(searchApiStatus_Final.RateLimitReset_UnixEpochSeconds, startTime.ToUnixTimeSeconds()); - Assert.AreEqual(searchApiStatus_Initial.RateLimit, searchApiStatus_Final.RateLimit); - Assert.IsTrue(searchApiStatus_Initial.RateLimitReset_DateTime == searchApiStatus_Final.RateLimitReset_DateTime || searchApiStatus_Initial.RateLimitReset_DateTime == searchApiStatus_Final.RateLimitReset_DateTime.Subtract(TimeSpan.FromSeconds(1))); if (searchApiStatus_Final.RateLimitReset_DateTime == searchApiStatus_Initial.RateLimitReset_DateTime) + { + Assert.AreEqual(searchApiStatus_Initial.RateLimit, searchApiStatus_Final.RateLimit); + Assert.IsTrue(searchApiStatus_Initial.RateLimitReset_DateTime == searchApiStatus_Final.RateLimitReset_DateTime || searchApiStatus_Initial.RateLimitReset_DateTime == searchApiStatus_Final.RateLimitReset_DateTime.Subtract(TimeSpan.FromSeconds(1))); Assert.GreaterOrEqual(searchApiStatus_Initial.RateLimitReset_TimeRemaining.TotalMilliseconds, searchApiStatus_Final.RateLimitReset_TimeRemaining.TotalMilliseconds); - Assert.AreEqual(searchApiStatus_Initial.RateLimitReset_UnixEpochSeconds, searchApiStatus_Final.RateLimitReset_UnixEpochSeconds); - Assert.GreaterOrEqual(searchApiStatus_Initial.RemainingRequestCount, searchApiStatus_Final.RemainingRequestCount); + Assert.AreEqual(searchApiStatus_Initial.RateLimitReset_UnixEpochSeconds, searchApiStatus_Final.RateLimitReset_UnixEpochSeconds); + Assert.GreaterOrEqual(searchApiStatus_Initial.RemainingRequestCount, searchApiStatus_Final.RemainingRequestCount); + } } [Test] diff --git a/src/GitHubApiStatus.UnitTests/Tests/GetApiRateLimitsTests_WithCancellationToken.cs b/src/GitHubApiStatus.UnitTests/Tests/GetApiRateLimitsTests_WithCancellationToken.cs index a2d6d02..505c01f 100644 --- a/src/GitHubApiStatus.UnitTests/Tests/GetApiRateLimitsTests_WithCancellationToken.cs +++ b/src/GitHubApiStatus.UnitTests/Tests/GetApiRateLimitsTests_WithCancellationToken.cs @@ -130,12 +130,14 @@ public async Task GetApiRateLimits_ValidSearchApiRequest() Assert.GreaterOrEqual(searchApiStatus_Final.RateLimitReset_DateTime, startTime); Assert.GreaterOrEqual(searchApiStatus_Final.RateLimitReset_UnixEpochSeconds, startTime.ToUnixTimeSeconds()); - Assert.AreEqual(searchApiStatus_Initial.RateLimit, searchApiStatus_Final.RateLimit); - Assert.GreaterOrEqual(searchApiStatus_Final.RateLimitReset_DateTime, searchApiStatus_Initial.RateLimitReset_DateTime); if (searchApiStatus_Final.RateLimitReset_DateTime == searchApiStatus_Initial.RateLimitReset_DateTime) + { + Assert.AreEqual(searchApiStatus_Initial.RateLimit, searchApiStatus_Final.RateLimit); + Assert.GreaterOrEqual(searchApiStatus_Final.RateLimitReset_DateTime, searchApiStatus_Initial.RateLimitReset_DateTime); Assert.GreaterOrEqual(searchApiStatus_Initial.RateLimitReset_TimeRemaining, searchApiStatus_Final.RateLimitReset_TimeRemaining); - Assert.AreEqual(searchApiStatus_Initial.RateLimitReset_UnixEpochSeconds, searchApiStatus_Final.RateLimitReset_UnixEpochSeconds); - Assert.GreaterOrEqual(searchApiStatus_Initial.RemainingRequestCount, searchApiStatus_Final.RemainingRequestCount); + Assert.AreEqual(searchApiStatus_Initial.RateLimitReset_UnixEpochSeconds, searchApiStatus_Final.RateLimitReset_UnixEpochSeconds); + Assert.GreaterOrEqual(searchApiStatus_Initial.RemainingRequestCount, searchApiStatus_Final.RemainingRequestCount); + } } [Test]