Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible mistakes in the "Tangram under the hood" page in documentation website #123

Open
shashkat opened this issue Jun 30, 2024 · 0 comments

Comments

@shashkat
Copy link

Hello there, firstly thanks for making this amazing and easy to use tool!

I was actually going through the documentation to better understand how Tangram works and was a bit confused about the explanation in the "Tangram under the hood" page in the documentation website (https://tangram-sc.readthedocs.io/en/latest/working.html).

I think there may be two typos in the website, which I crosschecked by going into the explanation of the workings in the Tangram manuscript.

As we can see in the image below, the shape of matrix M is said to be voxels by cells, which would make the matrix multiplication $M^{T}S$ invalid as shape of S is cells by genes. Secondly, in the loss function, we seem to have (positive) sum of cosine similarities, which is not what we would want as that is exactly the quantity we would like to maximize, not minimize.
tangram_website_mistakes

Below image highlights the correct statements in the manuscript's methods.
tangram_manuscript_details

Regards,
Shashank Katiyar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant