ref(tests): Removes network calls from unit tests

We've had several tests for a while that were in unit tests doing things
like network calls. All network call tests have been moved to integration
tests and some cleanup and refactoring was done as well.

I also changed the plugin test to just use a committed wash plugin binary.
The code is still in the repo (and updated to use the new wkg fetching),
but it added a significant delay because it compiled both `wash` and the
plugin. With a committed binary, it becomes much faster

Signed-off-by: Taylor Thomas <taylor@cosmonic.com>

Author: thomastaylor312

.github/workflows/wash.yml

@@ -20,7 +20,7 @@ concurrency:
 env:
   CARGO_TERM_COLOR: always
   GO_VERSION: '1.23'
-  TINYGO_VERSION: '0.33.0'
+  TINYGO_VERSION: '0.34.0'
 
 permissions:
   contents: read

crates/wash-cli/tests/wash_build.rs

@@ -423,7 +423,7 @@ async fn integration_build_rust_component_signed_with_signing_keys_directory_con
     name = "Hello World"
     language = "rust"
     type = "component"
-    
+
     [component]
     claims = ["wasmcloud:httpserver"]
     key_directory = "./haljordankeys"
@@ -576,12 +576,12 @@ async fn integration_build_tinygo_component_unsigned() -> Result<()> {
         .context("Failed to build project")?;
 
     assert!(status.success());
-    let unsigned_file = project_dir.join("build/http-hello-world.wasm");
+    let unsigned_file = project_dir.join("build/hello-world-tinygo.wasm");
     assert!(
         tokio::fs::try_exists(unsigned_file).await.unwrap(),
         "unsigned file not found!"
     );
-    let signed_file = project_dir.join("build/http_hello_world_s.wasm");
+    let signed_file = project_dir.join("build/hello_world_tinygo_s.wasm");
     assert!(
         !tokio::fs::try_exists(signed_file).await.unwrap(),
         "signed file should not exist when using --build-only!"
@@ -743,7 +743,7 @@ async fn integration_build_tinygo_component_separate_paths() -> Result<()> {
     path = "../"
     wit = "../wow"
     build = "artifacts"
-    
+
     [component]
     wit_world = "hello"
     wasm_target = "wasm32-wasip2"

crates/wash-lib/src/app.rs

@@ -513,10 +513,6 @@ mod test {
     use anyhow::Result;
 
     #[test]
-    #[cfg_attr(
-        not(can_reach_raw_githubusercontent_com),
-        ignore = "raw.githubusercontent.com is not reachable"
-    )]
     fn test_app_manifest_source_from_str() -> Result<(), Box<dyn std::error::Error>> {
         // test stdin
         let stdin = AppManifestSource::from_str("-")?;
@@ -595,57 +591,6 @@ mod test {
         Ok(())
     }
 
-    #[tokio::test]
-    #[cfg_attr(
-        not(can_reach_raw_githubusercontent_com),
-        ignore = "raw.githubusercontent.com is not reachable"
-    )]
-    async fn test_load_app_manifest() -> Result<()> {
-        // test stdin
-        let stdin = AppManifestSource::AsyncReadSource(Box::new(std::io::Cursor::new(
-            "iam batman!".as_bytes(),
-        )));
-
-        let manifest = load_app_manifest(stdin).await?;
-        assert!(
-            matches!(manifest, AppManifest::SerializedModel(manifest) if manifest == "iam batman!"),
-            "expected AppManifest::SerializedModel('iam batman!')"
-        );
-
-        // create temporary file for this test
-        let tmp_dir = tempdir()?;
-        std::fs::write(tmp_dir.path().join("foo.yaml"), "foo")?;
-
-        // test file
-        let file = AppManifestSource::from_str(tmp_dir.path().join("foo.yaml").to_str().unwrap())?;
-        let manifest = load_app_manifest(file).await?;
-        assert!(
-            matches!(manifest, AppManifest::SerializedModel(manifest) if manifest == "foo"),
-            "expected AppManifest::SerializedModel('foo')"
-        );
-
-        // test url
-        let url = AppManifestSource::from_str(
-            "https://raw.githubusercontent.com/wasmCloud/wasmCloud/main/examples/rust/components/http-hello-world/wadm.yaml",
-        )?;
-
-        let manifest = load_app_manifest(url).await?;
-        assert!(
-            matches!(manifest, AppManifest::SerializedModel(_)),
-            "expected AppManifest::SerializedModel(_)"
-        );
-
-        // test model
-        let model = AppManifestSource::from_str("foo")?;
-        let manifest = load_app_manifest(model).await?;
-        assert!(
-            matches!(manifest, AppManifest::ModelName(name) if name == "foo"),
-            "expected AppManifest::ModelName('foo')"
-        );
-
-        Ok(())
-    }
-
     #[tokio::test]
     async fn test_resolve_relative_manifest() -> Result<()> {
         let tmp_dir = tempdir()?;

crates/wash-lib/src/start/github/api.rs

@@ -31,7 +31,8 @@ async fn get_chronologically_sorted_releases(
     Ok(releases_of_repo)
 }
 
-async fn new_patch_releases_of_after(
+/// Get a full list of github patch releases that exist after the provided version.
+pub async fn new_patch_releases_after(
     owner: &str,
     repo: &str,
     after_version: &Version,
@@ -49,6 +50,7 @@ async fn new_patch_releases_of_after(
     Ok(main_releases)
 }
 
+/// Returns the latest patch version of the provided version.
 pub async fn new_patch_version_of_after_string(
     owner: &str,
     repo: &str,
@@ -59,7 +61,7 @@ pub async fn new_patch_version_of_after_string(
         Ok(v) => v,
         Err(_) => return Ok(None),
     };
-    match new_patch_releases_of_after(owner, repo, &after_version).await {
+    match new_patch_releases_after(owner, repo, &after_version).await {
         Ok(patches) => match patches.first() {
             Some(patch) => Ok(patch.get_main_artifact_release()),
             None => Ok(None),
@@ -297,36 +299,4 @@ mod tests {
         let version = release_with_prefix.get_main_artifact_release();
         assert!(version.is_none());
     }
-
-    /// Test if the GitHubRelease struct is parsed correctly from the raw string.
-    /// Using an already "outdated" patch version to test if the sorting works correctly and comparable to the current version.
-    #[tokio::test]
-    #[cfg_attr(not(can_reach_github_com), ignore = "github.com is not reachable")]
-    async fn test_fetching_wasm_cloud_patch_versions_after_v_1_0_3() {
-        let owner = &"wasmCloud";
-        let repo = &"wasmCloud";
-        let latest_version = semver::Version::new(1, 0, 3);
-        // Use 1.0.3 as the latest version, since there is a newer version
-        let releases = get_chronologically_sorted_releases(owner, repo, &latest_version).await;
-        assert!(releases.is_ok());
-        let patch_releases = new_patch_releases_of_after(owner, repo, &latest_version).await;
-        assert!(patch_releases.is_ok());
-        let patch_releases = patch_releases.unwrap();
-        for new_path_release in patch_releases {
-            let version_of_new_release = new_path_release.get_main_artifact_release();
-            assert!(
-                version_of_new_release.is_some(),
-                "new patch version is semver conventional versions"
-            );
-            let semver::Version {
-                major,
-                minor,
-                patch,
-                ..
-            } = version_of_new_release.unwrap();
-            assert_eq!(latest_version.major, major, "major version is not changed");
-            assert_eq!(latest_version.minor, minor, "minor version is not changed");
-            assert!(latest_version.patch < patch, "patch version is bigger");
-        }
-    }
 }